Eyal Paz comments

Results 12 comments of


                                            Eyal Paz

fix: time bug in ws_cilent

@yliaog Can you please have a look?

fix: only run h2c & http servers when needed

Yes, Will do

Add test for optional address value in httproute

/assign

Add test for optional address value in httproute

Sure! Basically it's a follow up to #3616, we need a test to check that implementations that will support an empty address value in `Gateway.Spec.Addresses.Value` behave correctly (accepted and assigned...

Add test for optional address value in httproute

/remove-lifecycle rotten

h2c server always runs in echo-basic container, even if not being tested

/assign

Group is not optional in LocalObjectReference

Hi @youngnick , is there still something to do here?

Group is not optional in LocalObjectReference

can i be assigned to this?

Group is not optional in LocalObjectReference

/assign

GEP-1767 confuses HTTPCORSFilter.AllowCredentials being set with HTTP request containing credentials

I agree that there is an issue with the phrasing, nice catch It appears that this test case doesn't appear in the CORS Tests PR yet, but you are definitely...