gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard
verified publisher icon kubernetes-sigs

fix: only run h2c & http servers when needed

Open EyalPazz opened this issue 10 months ago • 5 comments

What type of PR is this?

/kind bug /area conformance

Which issue(s) this PR fixes: Fixes #3594

Does this PR introduce a user-facing change?:

NONE

EyalPazz avatar Feb 13 '25 13:02 EyalPazz

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EyalPazz Once this PR has been reviewed and has the lgtm label, please assign kflynn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 13 '25 13:02 k8s-ci-robot

Hi @EyalPazz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Feb 13 '25 13:02 k8s-ci-robot

I don't see the concern with having a second server running - asked the question here https://github.com/kubernetes-sigs/gateway-api/issues/3594#issuecomment-2660233855

/hold

dprotaso avatar Feb 14 '25 20:02 dprotaso

Same question as @dprotaso but in the meantime

/ok-to-test

mikemorris avatar Feb 20 '25 19:02 mikemorris

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jun 25 '25 11:06 k8s-triage-robot

Yes, Will do

EyalPazz avatar Jul 09 '25 14:07 EyalPazz

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Aug 08 '25 15:08 k8s-triage-robot

@EyalPazz given the feedback that there doesn't seem to be a very strong need, and that this is a minor optimization, I'm going to close it and the original issue based on staleness.

/close

However please note that this doesn't mean we won't accept it if you want to go at it again, just let us know! :vulcan_salute:

shaneutt avatar Aug 25 '25 18:08 shaneutt