Kang-Che Sung (宋岡哲)
Kang-Che Sung (宋岡哲)
@fasterit Merged too fast. I think some of the commits should have been squashed before merging. Otherwise we would have small fixup commits forever in the history of `main`. (It's...
> Please explain those magic numbers … It's a bit difficult to explain in code. I wonder if you or other people have ideas to make the code more readable...
> LGTM. Although a bit unconventional to skip from `ns` to `ms` right away … Also, even though we have Unicode, for units I'd still prefer to use `us` unconditionally....
> Can we have one "format times" code as in #1583 and this combined? The output of #1583 is an ASCII string (`char []`), potentially allowing UTF-8. The output of...
> Using `us` instead of `µs` was suggested in my comment mostly for two reasons: > > 1. Avoids distinguishing cases in the code whether Unicode is available or not....
@BenBE It's likely a `configure` option with a possibly of statically linking it. The issue I see is the library's soname version is not quite stable as I would expect....
@BenBE The API I was considering right now is `uc_graphemeclusterbreak_property()`, that is, simply retrieving the "Grapheme_Cluster_Break" property from the database. The other functions can't work directly with htop's `RichString` so...
@rubyFeedback I'm personally also reluctant to introduce an additional dependency to htop, so yes, I expect the dependency can be turned off with a configure option as you said. Currently,...
I was evaluating three libraries that have the potential of supporting grapheme break detection needed for htop. The three libraries are: [ICU4C](https://unicode-org.github.io/icu/userguide/icu4c/) from Unicode, [libunistring](https://www.gnu.org/software/libunistring/) from GNU, and [libgrapheme](https://libs.suckless.org/libgrapheme/) from...
@BenBE What surprised me is that none of the three libraries provided the low level interfaces that I consider to Keep It Simple and to Do One Thing Well. While...