htop-dev
Add an option to hide or show Cache and Buffers in Graph mode
This PR covers issue #407.
[x] Show cached memory in graph
Added this option to "Display Options". It's enabled by default to be compatible with current behavior. Disabling it will remove Cache and Buffers memory from Memory Graph and Mem&Swp Graph.
I expect this PR be rebased on / merged with #928. Otherwise I fear this would conflict with the multi-color graph feature I already proposed in #714.
I expect this PR be rebased on / merged with #928. Otherwise I fear this would conflict with the multi-color graph feature I already proposed in #714.
No problem. I can rebase as soon as #928 is merged. Otherwise I don't know what to do.
The actual change looks good (should be one commit though, not two), but I'm not very eager about the feature overall.
@fasterit @natoscott What do you think?
I think for consistency reasons this switch should also affect the bar mode. I'm not against it, it's small and fits a use case of seeing how much memory is used and not-easily evictable. /DLange
@fasterit @natoscott What do you think? I'm not against it, it's small and fits a use case [...]
I don't love it, as it adds yet another configurable option many people wont need and the Options menu is already cluttered. OTOH I don't see any better solution, so I wont object to it being added.
@fasterit Merged too fast. I think some of the commits should have been squashed before merging. Otherwise we would have small fixup commits forever in the history of main. (It's not my call, but I just suggest to be careful next time.)
I cleaned up the history (squashing the merge + amended commit). AFAICS only one fork (that I follow/fetch) pulled that commit by the time I force-pushed the updated tip.