Kang-Che Sung (宋岡哲)

Results 428 comments of Kang-Che Sung (宋岡哲)

I don't have any more comment with this code now. But perhaps is good to explain what's the difference between this PR and #1643. Does this supersede #1643? Cc @aestriplex

@Korrd Please keep in mind I'm just a volunteer. While I can help evaluting the quality of the patches, I don't have all day to do it and I have...

I slightly reordered the logic of the `Platform_calculateNanosecondsPerMachTick` function: ```c static void Platform_calculateNanosecondsPerMachTick(uint64_t* numer, uint64_t* denom) { // Check if we can determine the timebase used on this system. //...

https://stackoverflow.com/questions/67839938/why-is-snprintf-not-considered-async-safe

Since the `CRT_handleSIGTERM` function simply exits after printing the diagnostic message, I wonder if the problem can be fixed by simply blocking other signals before calling `snprintf(3)`? I mean, will...

Related to this bug. The `signal_safe_fprintf()` function in Settings.c is not quite "signal safe" as the function says, and should be fixed as well.

@rustedusted There are two main things to address regarding the whole issue of Bar meter characters: 1. The "subpixel" rendering. (Technically it's character cell not pixel, but anyway.) It would...

@rustedusted What are you doing? Try [git rebase](https://git-scm.com/docs/git-rebase) with `-i` option and it can help you with many things. No need to make another pull request.

@rustedusted I don't recommend breaking existing discussions so I would suggest you to keep this branch `main` for now unless you really want the PR to be closed. You can...

I expect this PR be rebased on / merged with #928. Otherwise I fear this would conflict with the multi-color graph feature I already proposed in #714.