Mark Amery

Results 116 comments of Mark Amery

Hmm, some of the stuff in the diff is also clearly the result of @donatj's version being forked off Drupal Coder before some of the most recent commits. For instance,...

A slimmed-down diff with the above point in mind, showing only @donatj's actual changes: ``` diff 56,57c56,58 < $classUsed = $phpcsFile->findNext(T_STRING, ($classPtr + 1)); < $lowerClassName = strtolower($tokens[$classPtr]['content']); --- >...

Hi @prevostc. Sorry for 'abandoning' this - I keep intending to come back to it, and never quite doing so. All that remains to be done here is understanding @donatj's...

Yep @gmponos handling your use case is one of the things that @donatj's changes will handle - it's what I was talking about above when I said that > adding...

I've come back to this in the last few days and made a bunch of progress, mostly in the form of adding failing tests that reveal existing bugs or omissions....

Made some progress today. Still TODO: - [ ] Handle `const` and `function` use statements, including inside group use declarations - [ ] I think this will require fixing an...

> what I am doing wrong? I'm going to have a go at reproducing this now and see if I can find out. As a possible starting point: on my...

I can reproduce this just fine using eggyal's example query (as long as I create a table called `宍`); the comment syntax issue was my only difficulty. What error are...

Aha, I just noticed http://programmers.stackexchange.com/questions/232791/slight-extension-for-sql-prepared-statements-syntax-need-advice after you linked to it from another issue here. It sounds like you're consdering addressing the problem that my ?k and ?m placeholders solve via...

I didn't open the issue because I was concerned that the bugs might be unfixed, but rather because these bug numbers are effectively broken links - issue references that can't...