Mark Amery
Mark Amery
And again a couple of hours ago.
The YAML being valid doesn't mean this should be closed, surely? Even if it's valid YAML, the behaviour here isn't useful; throwing an error indicating that this is valid YAML...
There are other options too, like parsing it into some structure other than an Object or taking an argument that indicates whether to throw on object keys or not. But...
Yeah, I'm not too familiar with ES6 maps but given the difference in interface it seems that using objects where possible and maps only where non-string keys are needed would...
Something else relevant: using an array as a key is apparently legal YAML, but results in a string representation of the array being used as the key. @puzrin: > You...
Looks like this blew up in Travis due to using `[]` array syntax which wasn't supported in PHP 5.3. Will change it to `array()` tomorrow.
Looking at other PRs that add sniffs, I see that I might want to add docs for this. Will look into doing so at some point.
Added some docs. I think this just needs review from @gsherwood now.
Thanks @donatj, I'll take a look when I have a chance and try to integrate and add tests for your improvements. I'll need to have a think/read to figure out...
I've returned to this to get it merge-ready, and have made some progress now and will finish tomorrow. Actions I've taken today: - Bringing this PR up to date with...