Sean Goldin

Results 22 comments of Sean Goldin

@xabirequejo, great! Since you looked it over, I am sure that @Dimillian will merge this sometime tomorrow. Thanks for taking the time and translating things!

Nice! I was going to work on this next—a few comments about the UI. I will put them in individual comments to more easily "talk" about them if necessary.

![CleanShot 2023-02-08 at 05 40 34@2x](https://user-images.githubusercontent.com/169561/217520333-62df13ef-6c42-4b65-8014-b16d0dd5b9fc.png)

![CleanShot 2023-02-08 at 05 42 36@2x](https://user-images.githubusercontent.com/169561/217520530-61a5094a-3713-4ed9-abea-4b57043e2ea4.png) One thing I notice is that because it is actionable, the state gets lost depending on what is tapped. No point adding any state...

The preview should stay in place. This will allow smaller phones to make changes further down the screen and still see what those changes would do.

![CleanShot 2023-02-08 at 05 47 08@2x](https://user-images.githubusercontent.com/169561/217521367-df027569-db73-4dcb-ae22-7add817201f1.png) Highly recommend showing the share icon here to get rid of the "whitespace" and make it look more uniform.

Again, I like what I see. I'm sorry if my suggestions don't come off as suggestions. I do mean them as such.

How about a more personalised post example? I don't know what to put, but I like what Ivory did. ![image](https://user-images.githubusercontent.com/169561/217524243-71f38f09-b6c7-40b0-9fa4-ed65c9643969.jpeg)

Here are some examples of how others handle this kind of customisation. I am just posting these here for inspiration for the **next** iteration of the settings page. ### Fastmail...

As for swipe xxx outer/inner, perhaps we can go for the text that the FastMail example uses?