Dimillian
swipe actions improvements
ok, changes for swipe actions:
settings
I added a new settings for Swipe actions and in there a section for swipe actions on posts (I can think of more places where it might be handy to configure swipes)
I'm not quite content with the wording for the 4 swipe entries (swipe left outer, swipe left inner) but have no better idea currently. It would be nice as well to have the icons in the picker entries, probably need to add them with the Text in some view.
I have defined an enum for these values that can provide the symbol names and display label keys, perhaps it might make sense to use this at other places as well so we would have the labels and icon names in one place to maintain; but that should be a different PR then.
I store this 4 values in the user preferences, would it be better to put them in a struct and serialize/deserialize that when the preferences are written?
display
For the outer one I used the tintColor, the inner one is gray. Alas it seems not to be possible to have the icons in a not-filled style, I would have liked to show the state of bookmarked faved etc in there. And I did not find a way to change the color of the icon/text in the swipes to something different than white.
The text is in the swipes for me during development, should I take it out or can we leave it in there?
left side
right side
Localizations for all languages besides en have not yet been added, waiting until all necessary changes are done
Here are some examples of how others handle this kind of customisation. I am just posting these here for inspiration for the next iteration of the settings page.
Fastmail application
ProtonMail
TickTick
As for swipe xxx outer/inner, perhaps we can go for the text that the FastMail example uses?
Another future feature is not allowing users to select the same swipe gesture multiple times. For instance, I can do this today:
Sorry about the rambling here.
As for swipe xxx outer/inner, perhaps we can go for the text that the FastMail example uses?
Like this one the best from the examples; although it seems that the SwiftUI "short" action does not really trigger the action, it just shows the two entries.
Could you please copy all the new
Localizable.stringsentries to the other languages? Otherwise, other languages get things like this.
I know, as I wrote, I wanted to wait until the PR is alright, converted to a draft PR until it's ready
btw is there a way to have the "short" action, the "inner" one to be triggered by just swiping out the short way?
btw is there a way to have the "short" action, the "inner" one to be triggered by just swiping out the short way?
I don't think it is possible using the stock controls.
Apple doesn't mention it anywhere on their page:
https://developer.apple.com/documentation/swiftui/view/swipeactions(edge:allowsfullswipe:content:)
I reworked the setting and now have this solution:
Seems to be more understandable