Erik Präntare

Results 21 comments of Erik Präntare

I would also appreciate this :)

I don't think there's a reason to switch the default to dark theme, but making it match the system theme would be an improvement imo (if it doesn't already do...

I got the impression that this project uses C++17. The following line should probably be edited in that case: https://github.com/btzy/nativefiledialog-extended/blob/d1b8b19bd09ef80eeb08d1a47db5a53eadbfb374/CMakeLists.txt#L24 `std::basic_string::c_str` accesses the underlying C-string, effectively acting the same way...

Checking the CMake docs, you're right. However, I think we may want to use the `CXX_STANDARD` property to not interfere with other CMake code (not related to this issue). Also,...

> I'm not too sure what you mean - it appears that CMAKE_CXX_STANDARD sets the default value of CXX_STANDARD on all targets, which is what we want here. This option...

I implemented a basic wrapper around the API in my project using nfde. Thought I'd show you how it looks/what I had in mind: ```cpp namespace util::nfd { namespace fs...

> Sorry, I was quite busy for the past few days. Indeed, this API looks quite concise, and it is nice that `std::filesystem::path` is internally stored as strings using the...

I don't think I can think of a situation where you'd want a sub-slice of a collection here. In any case, I also think iterators is the way to go....

The main reason to deprecate would be for simpler maintenance. I don't think iterator pairs will be seen as "wrong" before like 2030 though. I think the reason for the...

No big difference as far as I can see. One thing to keep in mind is that `begin` vs `std::begin` is more pemissive, so it would be easier to switch...