Roman Shanin

Results 142 comments of Roman Shanin

> There was a suggestion to use a different enum representation. It can be modified. At the moment I found this easier to implement I think current approach is fine,...

@appetrosyan, what kind of behavior we want to log with `debug`? If we are talking about errors during smartcontract execution, then we already log them inside functions that uses this...

As i understand `Genesis` represents initial state of blockchain, does it make sense to transfer assets on initial state?

IMO there is no point in this change currently. Our `AccountEvent::PermissionAdded/Removed` doesn't have any additional info only `AccountId`, so we would just spam with bunch of meaningless events. We should...

I'm a bit confused, we are going to have `OpCode` unique among all instructions or it would be unique per instruction (so with opcode we encode "overloading" of that instruction)?...

In general it looks good, however I have some thoughts about the `config` module, in the current state `Config` is a mix of different domains (peer: `SumeragiConfiguration`, `ToriiConfiguration`, system: `QueueConfig`,...

@Arjentix how is this related to permission validator approach you proposed? That everything is allowed until explicitly prohibited by some validator?

@appetrosyan, @mversic if we look [at](https://github.com/hyperledger/iroha/blob/iroha2-dev/data_model/src/expression.rs#L47): ```rust impl From for EvaluatesTo { fn from(expression: E) -> Self { Self { expression: expression.into(), _value_type: PhantomData::default(), } } } ``` Nothing prevent...

I think 2 also leads to more complex code, because we will need to keep up to date account permission tokens. Also small change in role permission would lead to...

> Second queue for multisig transactions But how we will decide which transaction is multisig?