Notify event listners when a role is Revoked

Open omkar-mohanty opened this issue 3 years ago • 3 comments

Problem

As noted in PR #2264 an account can lose a permission that's included in a role and event listeners that look for the permission being removed will not be notified.

Solution

It would be nice if event listeners that look for PermissionAdded / PermissionRemoved to also be notified if a role that contains this permission is being revoked.

May 27 '22 16:05 omkar-mohanty

Hi I would like to continue my work on this. Can I get assigned to this issue?

Jun 04 '22 04:06 omkar-mohanty

@omkar-mohanty hello, are there any updates regarding this issue?

Sep 12 '22 11:09 6r1d

Hi @6r1d I tried solving this issue for a long time and could not come up with anything. I think it"s best if it's reassigned to someone else.

Sep 12 '22 23:09 omkar-mohanty

IMO there is no point in this change currently. Our AccountEvent::PermissionAdded/Removed doesn't have any additional info only AccountId, so we would just spam with bunch of meaningless events.

We should firstly extend our events to contain more data.

Sep 27 '22 13:09 Erigara