Roman Shanin
Roman Shanin
> I was thinking that kagami genesis sign produces a genesis block? No, atm we [put](https://github.com/hyperledger/iroha/blob/f5e3c493a6f2f336da09d75c8d00562aac8168a5/core/src/sumeragi/main_loop.rs#L283) genesis transaction in the block builder. So it's not full block yet.
We also need `executor.wasm` when deploying iroha. Currently deployment download genesis and executor using direct links from github.
Also our docker-compose files rely on existence of `executor.wasm` implicitly trough `gensis.json`. Does end user suppose to build/download executor on their own?
[Github artifacts](https://docs.github.com/en/rest/actions/artifacts?apiVersion=2022-11-28) are tricky to deal with... We can't simply get artifact by it's name like `executor`. We either should specify artifact id which is not known in compose file...
Here is general [explanation](https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control) why tracking `Cargo.lock` might be helpful.
Formatting and clippy should be fine now :)
@YangKeao hello, do you have any estimates on reviewing this PR?
> You can see this in your playground link if you run it normally (i.e. not with miri) where the error if the alignments don't match displays that u128 is...
So currently we have following trigger execution order: 1. Data events are execute trigger events are produced depending on block content, and for triggers match order depends on trigger id...
@mversic is that should be documented somewhere?