John Ericson

Results 565 comments of John Ericson

Sorry I took so long. Finally sent in https://mail.haskell.org/pipermail/libraries/2019-April/029537.html

@sjakobi I recall it was mostly positive feedback? https://github.com/haskell/containers/pull/616 was the implementation. I'm sorry I've never finished it off, I've been busy with many other things.

Ah sorry this is annoying 1. `cabal install dist/alex-*.tar.gz` I think fails because this was removed in v2-build or something, just a guess. At least I am pretty sure I...

Yeah this looks good to me, and something I'd want too. I thought some of the wrappers might affect the error type, but no they don't, only `AlexInput` not `Alex....

Yeah I won't pull the trigger on this until I bring up on ghc-devs. Maybe we could have a flag to either use or not use the vendored part as...

Per https://github.com/simonmar/alex/pull/165, I would like to *unfuse* the UTF-8 and user-written automata to decluttter the implementation, which we speculate is a bit confused because it might predate `Char` properly supporting...

I just redid this. @dudebout, since you've been caring about this lately, want to review it?

@dudebout I didn't want to use `stdenv.cc` because `stdenv` hasn't been introduced yet! :) `hostPlatform.isDarwin` also hasn't been introduced, but I hope it's meaning is more easily guessed than `stdenv`.

OTOH, gcc does work on Darwin, or at least should...

@LnL7 Oh... it's not gcc but binutils that's the problem, right?