Eric Gao

Results 200 comments of Eric Gao

@duhanmin Hello, thanks for submitting this PR and it's a good feature. I've added some comments and please take a look.

The commit history of this PR looks pretty wired, could u plz fix it? Thx ![image](https://user-images.githubusercontent.com/34905992/195036020-827b4d62-5f4c-47ac-872b-56e0cf58cc7c.png)

This is a good feature. Could you please add a UT for it? Thanks.

Hi @MonsterChenzhuo May I ask whether you are still working on it?

@ruanwenjun @caishunfeng @SbloodyS Could u plz help take a look when available? Thanks : )

> > I've restarted failed jobs in CI, LGTM once CI passes. > > What do u want me to do ? Nothing actually, just wait for the CI to...

@fengjian1129 Good job! This is a handy feature, thanks again for the contribution!

BTW, we need to move these two dependencies from each module to root pom. https://github.com/apache/dolphinscheduler/blob/18ef0a66cb91d9dfe6406f8ade6cfb2cff36492e/dolphinscheduler-common/pom.xml#L63-L74