dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Improvement] [Alert] mask the password of email(#11913)

Open pandong2011 opened this issue 2 years ago • 5 comments

Purpose of the pull request

mask the password of email, telegram,feishu,dingtalk

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Manually verified the change by testing locally. (or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md email

pandong2011 avatar Sep 15 '22 07:09 pandong2011

@kezhenxu94 @caishunfeng

pandong2011 avatar Sep 15 '22 14:09 pandong2011

@pandong2011 hello, i cherry-pick this pr but found it does not work, can you help check again?

fhygh avatar Sep 16 '22 02:09 fhygh

@fhygh Okay, sure

pandong2011 avatar Sep 16 '22 07:09 pandong2011

Codecov Report

Merging #11959 (87eb6c0) into dev (e70c501) will increase coverage by 1.15%. The diff coverage is 54.66%.

@@             Coverage Diff              @@
##                dev   #11959      +/-   ##
============================================
+ Coverage     38.55%   39.70%   +1.15%     
- Complexity     4034     4190     +156     
============================================
  Files           993     1016      +23     
  Lines         36673    38061    +1388     
  Branches       4274     4368      +94     
============================================
+ Hits          14138    15112     +974     
- Misses        20912    21204     +292     
- Partials       1623     1745     +122     
Impacted Files Coverage Δ
...olphinscheduler/api/audit/AuditPublishService.java 34.61% <0.00%> (ø)
...duler/api/configuration/TaskTypeConfiguration.java 13.63% <0.00%> (+2.92%) :arrow_up:
...phinscheduler/api/controller/TenantController.java 62.50% <ø> (ø)
...eduler/api/dto/schedule/ScheduleFilterRequest.java 0.00% <0.00%> (ø)
...eduler/api/dto/workflow/WorkflowCreateRequest.java 100.00% <ø> (ø)
...eduler/api/dto/workflow/WorkflowFilterRequest.java 33.33% <ø> (ø)
...eduler/api/dto/workflow/WorkflowUpdateRequest.java 50.00% <ø> (ø)
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <ø> (ø)
...rg/apache/dolphinscheduler/api/k8s/K8sManager.java 58.53% <ø> (ø)
...che/dolphinscheduler/alert/AlertSenderService.java 46.00% <5.26%> (-3.65%) :arrow_down:
... and 187 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 19 '22 06:09 codecov-commenter

The commit history of this PR looks pretty wired, could u plz fix it? Thx image

EricGao888 avatar Oct 11 '22 08:10 EricGao888