dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Improvement][Test] Block the usage of `Powermock`

Open EricGao888 opened this issue 3 years ago • 1 comments

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

Description

  • We could block the usage of Powermock by Spotless.
  • Change the pre-commit hook from mvn spotless:apply to mvn spotless:check to avoid confusing.

related: #11405

Are you willing to submit a PR?

  • [X] Yes I am willing to submit a PR!

Code of Conduct

EricGao888 avatar Aug 25 '22 02:08 EricGao888

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

  • In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
  • If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

github-actions[bot] avatar Aug 25 '22 02:08 github-actions[bot]

BTW, we need to move these two dependencies from each module to root pom. https://github.com/apache/dolphinscheduler/blob/18ef0a66cb91d9dfe6406f8ade6cfb2cff36492e/dolphinscheduler-common/pom.xml#L63-L74

EricGao888 avatar Oct 11 '22 02:10 EricGao888