Eric Arellano

Results 191 comments of Eric Arellano

Hm it looks like this is the wrong repository to post this? I'm having a tough time finding where `refmt` is actually implemented.

> Only if the slice has a static lifetime. Otherwise the slice has to be copied regardless. Oh, hm, yeah you're right: https://docs.rs/bytes/1.1.0/bytes/struct.Bytes.html#method.copy_from_slice Good point. We can possibly change that...

An example sounds totally reasonable to me! I definitely would not want adding this convenience to impede future foundational improvements to PyO3.

Related: @chrisjrn and I decided that `` should not work with docker environments and remote enviroments: that would be very weird to have added `~/.pexrc` inside either of those environments/containers...Instead,...

> this is still a problem even with your patch - I just hit it running on PANTS_SHA https://github.com/pantsbuild/pants/commit/f06bf22be82a51200545a5ed936860888f8a840b Same stracktrace as the OP?

@danxmoran it would be helpful to run with `--no-remote-cache-read --no-local-cache --no-pantsd`.

Thanks @erjac77 ! Great improvement :)

Thanks for the suggestion! I like this idea. One nuance her: we have the notion of "build_ignore" vs "pants_ignore". "build_ignore" only means "don't look for BUILD files in this dir/glob",...

> I don't remember how tailor interacts with build_ignore though. It probably doesn't respect it? It respects it. See last paragraph of this option we have: https://github.com/pantsbuild/pants/blob/72e73a376f67efd953392cc88f25e8f1e0190b60/src/python/pants/core/goals/tailor.py#L313-L326

This still needs to be wired up to Python, which will be possible once https://github.com/pantsbuild/pants/pull/16764 lands. For now, I will hardcode the value. Edit: open question to me where the...