Eric Arellano

Results 194 comments of Eric Arellano

Hello! Do you know if it's only failing for certain things like credentials? I wonder if you could get a trivial "hello world" `docker_image` to build, something as simple as...

Re: `cpp_sources` vs `c_sources`, I think this depends on how much the different tools are going to work with both C and C++. For example, test runners, formatters, linters. If...

> One issue is that we'd have this compiler field potentially proliferate to more than just sources, which is a "problem" I'm running into today. I don't think I'm following...

> If we have all C++ sources, use the C++ linker frontend. And if we have mixed sources, use C++. > > So, it's just a matter of noting whether...

> Not trying to be dense here, but if this was set to "auto" for all sources, then how would we infer/determine if C++ was used from this field? "auto"...

> I guess I'm having a hard time envisioning where CompilerField.normalized_value(CCSourcesField) would get changed in the compilation pipeline. When compiling the file, you will consult the field to know which...

Thanks! > This PR currently vendors the Tower TimeoutLayer in order to allow the addition of a timeout metric. I'm not following why we need to vendor, rather than importing...

Thanks for the suggestion! I like this - we want to reduce the need for writing custom plugins when possible. This also semi relates to https://github.com/pantsbuild/pants/issues/10399. FYI the reason we...

> Likely also related to #7022. Sort of. If "target generation" lands, that will mean that you can write much more powerful macros that have access to the Rules API....

> With https://github.com/pantsbuild/pants/issues/7022 , how to write a macro to set by the env variable? Hey @da-tubi, the result of #7022 was the new Target Generator API added in Pants...