Eli C. Lowry
Eli C. Lowry
*[`src/SIL.Machine/Corpora/ParatextProjectTermsCorpusBase.cs` line 42 at r3](https://reviewable.io/reviews/sillsdev/machine/233#-O4Rzh-S62_Ggr7CuC5H:-O4evyzE5I0_6WwlLwrP:bl5kitg) ([raw file](https://github.com/sillsdev/machine/blob/ec31107bd421cbcb187bf68153c1329ab8a3a744/src/SIL.Machine/Corpora/ParatextProjectTermsCorpusBase.cs#L42)):* Previously, Enkidu93 (Eli C. Lowry) wrote… It was previously in the constructor. The issue is that in the zip child class, the `_archive`...
*[`src/SIL.Machine/Corpora/ZipParatextProjectTermsCorpus.cs` line 7 at r3](https://reviewable.io/reviews/sillsdev/machine/233#-O4Rvx244R43rR7Krbu-:-O4gMonzEoDMz1JwMacn:b-m27znj) ([raw file](https://github.com/sillsdev/machine/blob/ec31107bd421cbcb187bf68153c1329ab8a3a744/src/SIL.Machine/Corpora/ZipParatextProjectTermsCorpus.cs#L7)):* Previously, ddaspit (Damien Daspit) wrote… You can leave the names the way they are. It is unfortunate that they follow different naming schemes,...
OK, is this something we should try to fix there or something we need to handle more robustly in Machine itself?
We've seen a few more of these errors on the rancher alerts, so maybe we should escalate this issue. It also shouldn't be terribly difficult to fix, right? And there...
> [@Enkidu93](https://github.com/Enkidu93) - what is the current status of this? Do we need to use https://www.nuget.org/packages/ParatextData? Yes, we can either use ParatextData or implement it ourself following ParatextData's implementation.
I'm going to try to put a PR into SIL.Scripture today. Not sure how long that review process will be.
Where was this completed, @johnml1135 ? This involves adding new methods to the CorpusExtensions in parallel with those that exist for ParallelTextCorpus and was not part of my NParallelTextCorpus PR.
> My fault - I thought that it was already done. Is this needed for anything? We are currently doing operations on arrays of corpora rather than using NParrallelTextCorpus directly....
Any updates on this?
> Sorry, I completely forgot about this. I doubt it is intentional, and it probably just happened to be that way. It's possible it has something to do with the...