machine icon indicating copy to clipboard operation
machine copied to clipboard
verified publisher icon sillsdev

Implement corpus operators supported by ParallelTextCorpus for NParallelTextCorpus

Open Enkidu93 opened this issue 1 year ago • 3 comments

Enkidu93 avatar Nov 13 '24 22:11 Enkidu93

Where was this completed, @johnml1135 ? This involves adding new methods to the CorpusExtensions in parallel with those that exist for ParallelTextCorpus and was not part of my NParallelTextCorpus PR.

Enkidu93 avatar Dec 04 '24 13:12 Enkidu93

My fault - I thought that it was already done. Is this needed for anything? We are currently doing operations on arrays of corpora rather than using NParrallelTextCorpus directly. Therefore, are the corpus extensions needed?

johnml1135 avatar Dec 04 '24 14:12 johnml1135

My fault - I thought that it was already done. Is this needed for anything? We are currently doing operations on arrays of corpora rather than using NParrallelTextCorpus directly. Therefore, are the corpus extensions needed?

No worries. I don't think any of these are things we'd actively need to use, but Damien wanted them in there more for completeness sake/for non-Serval use.

Enkidu93 avatar Dec 04 '24 14:12 Enkidu93