Innokentii Mokin

Results 11 comments of Innokentii Mokin

Wow, thanks for review, it was PoC to build under MSVC and I didn't think you would review it until I publish it (now it is a draft). I will...

I added unit tests, but unsure about right placement. Correct me if I'm wrong. I also changed naming so, it's not so straightforward to add a switch in configure and...

Just built and run some examples under windows with reduced perf and functionality: - disabled fy-tool - commented mmap-related functionality - commented termios related things (probably slightly affects output in...

# Current diff for simplified configs processing output ## block-4-2.yaml.result.json ```diff @ ["ActorSystemConfig"] # ok - {"BatchExecutor":2,"Executor":[{"Name":"System","Threads":2,"Type":"BASIC"},{"Name":"User","Threads":3,"Type":"BASIC"},{"Name":"Batch","Threads":2,"Type":"BASIC"},{"Name":"IO","Threads":1,"TimePerMailboxMicroSecs":100,"Type":"IO"},{"Name":"IC","SpinThreshold":10,"Threads":1,"TimePerMailboxMicroSecs":100,"Type":"BASIC"}],"IoExecutor":3,"Scheduler":{"ProgressThreshold":10000,"Resolution":256,"SpinThreshold":0},"ServiceExecutor":[{"ExecutorId":4,"ServiceName":"Interconnect"}],"SysExecutor":0,"UserExecutor":1} @ ["BlobStorageConfig","ServiceSet","PDisks",7,"PDiskCategory"] # suspicios - 1 @ ["BlobStorageConfig","ServiceSet","PDisks",6,"PDiskCategory"] # suspicios - 1 @...

Updated after extracting dependent PRs #1990 and #1973

Maybe a part of the diff above is not an issue. I just found that later in transformation pipeline in `driver_lib` we set up DummyActorSystemConfig, so, I will check the...

> > Maybe a part of the diff above is not an issue. I just found that later in transformation pipeline in `driver_lib` we set up DummyActorSystemConfig, so, I will...

Okay, I still have some doubts about these changes. Especially about next ones. I have to double check that it won't break anything. ```diff @ ["BlobStorageConfig","ServiceSet","PDisks",7,"PDiskCategory"] # suspicios - 1...

So, alexvru@ told that we probably shouldn't remove `PDiskCategory`, because in this case we may get `ROT` behaviour instead of `SSD` And ``` @ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"PoolConfig","PDiskFilter"] ``` also critically important

The same for legacy service -- we can't disable it. Storage just won't start.