ydb icon indicating copy to clipboard operation
ydb copied to clipboard

Published 20 hours ago • verified publisher icon ydb-platform

Simplify example configurations [PR#1536 port to new configs]

Open Enjection opened this issue 1 year ago • 16 comments

Changelog entry

  • Allow to specify type: RAM in configuration for in-memory disks.
  • Allow to specify default disk type, erasure species, and TLS settings only once.
  • Allow to skip explicitly specifying vdisk_kind.
  • Assume all hosts are in the same datacenter but distinct bodies and racks, unless specified otherwise.
  • Clean-up example configs.

Changelog category

  • New feature

Additional information

...

Enjection avatar Feb 15 '24 10:02 Enjection

:white_circle: 2024-02-15 10:57:59 UTC Pre-commit check for a1ad02bff75cb6a0955fb9d71950917e019687eb has started. :white_circle: 2024-02-15 10:58:01 UTC Build linux-x86_64-relwithdebinfo is running... :green_circle: 2024-02-15 11:41:29 UTC Build successful. :white_circle: 2024-02-15 11:41:38 UTC Tests are running... :red_circle: 2024-02-15 13:11:17 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67432 56420 0 4 10972 36

github-actions[bot] avatar Feb 15 '24 10:02 github-actions[bot]

:white_circle: 2024-02-15 11:00:26 UTC Pre-commit check for a1ad02bff75cb6a0955fb9d71950917e019687eb has started. :white_circle: 2024-02-15 11:00:29 UTC Build linux-x86_64-release-asan is running... :green_circle: 2024-02-15 11:40:32 UTC Build successful. :white_circle: 2024-02-15 11:40:46 UTC Tests are running... :red_circle: 2024-02-15 13:17:21 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14783 14579 0 17 121 66

github-actions[bot] avatar Feb 15 '24 11:02 github-actions[bot]

Current diff for simplified configs processing output

block-4-2.yaml.result.json

@ ["ActorSystemConfig"] # ok
- {"BatchExecutor":2,"Executor":[{"Name":"System","Threads":2,"Type":"BASIC"},{"Name":"User","Threads":3,"Type":"BASIC"},{"Name":"Batch","Threads":2,"Type":"BASIC"},{"Name":"IO","Threads":1,"TimePerMailboxMicroSecs":100,"Type":"IO"},{"Name":"IC","SpinThreshold":10,"Threads":1,"TimePerMailboxMicroSecs":100,"Type":"BASIC"}],"IoExecutor":3,"Scheduler":{"ProgressThreshold":10000,"Resolution":256,"SpinThreshold":0},"ServiceExecutor":[{"ExecutorId":4,"ServiceName":"Interconnect"}],"SysExecutor":0,"UserExecutor":1}
@ ["BlobStorageConfig","ServiceSet","PDisks",7,"PDiskCategory"] # suspicios
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",6,"PDiskCategory"] # suspicios
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",5,"PDiskCategory"] # suspicios
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",4,"PDiskCategory"] # suspicios
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",3,"PDiskCategory"] # suspicios
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",2,"PDiskCategory"] # suspicios
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",1,"PDiskCategory"] # suspicios
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",0,"PDiskCategory"] # suspicios
- 1
@ ["ChannelProfileConfig"] # suspicios
- {"Profile":[{"Channel":[{"ErasureSpecies":"block-4-2","PDiskCategory":1,"StoragePoolKind":"ssd"},{"ErasureSpecies":"block-4-2","PDiskCategory":1,"StoragePoolKind":"ssd"},{"ErasureSpecies":"block-4-2","PDiskCategory":1,"StoragePoolKind":"ssd"}],"ProfileId":0}]}
@ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"Kind"] # suspicios
- "ssd"
@ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"PoolConfig","Kind"] # suspicios
- "ssd"
@ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"PoolConfig","PDiskFilter"] # suspicios
- [{"Property":[{"Type":"SSD"}]}]
@ ["GRpcConfig","ServicesEnabled"] # suspicios
- ["legacy"]
@ ["NameserviceConfig","Node",7,"WalleLocation"] # ok
- {"Body":8,"DataCenter":"zone-a","Rack":"8"}
@ ["NameserviceConfig","Node",7,"Location"] # ok
+ {"Body":8,"DataCenter":"default","Rack":"generated-rack-8"}
@ ["NameserviceConfig","Node",6,"WalleLocation"] # ok
- {"Body":7,"DataCenter":"zone-a","Rack":"7"}
@ ["NameserviceConfig","Node",6,"Location"] # ok
+ {"Body":7,"DataCenter":"default","Rack":"generated-rack-7"}
@ ["NameserviceConfig","Node",5,"WalleLocation"] # ok
- {"Body":6,"DataCenter":"zone-a","Rack":"6"}
@ ["NameserviceConfig","Node",5,"Location"] # ok
+ {"Body":6,"DataCenter":"default","Rack":"generated-rack-6"}
@ ["NameserviceConfig","Node",4,"WalleLocation"] # ok
- {"Body":5,"DataCenter":"zone-a","Rack":"5"}
@ ["NameserviceConfig","Node",4,"Location"] # ok
+ {"Body":5,"DataCenter":"default","Rack":"generated-rack-5"}
@ ["NameserviceConfig","Node",3,"WalleLocation"] # ok
- {"Body":4,"DataCenter":"zone-a","Rack":"4"}
@ ["NameserviceConfig","Node",3,"Location"] # ok
+ {"Body":4,"DataCenter":"default","Rack":"generated-rack-4"}
@ ["NameserviceConfig","Node",2,"WalleLocation"] # ok
- {"Body":3,"DataCenter":"zone-a","Rack":"3"}
@ ["NameserviceConfig","Node",2,"Location"] # ok
+ {"Body":3,"DataCenter":"default","Rack":"generated-rack-3"}
@ ["NameserviceConfig","Node",1,"WalleLocation"] # ok
- {"Body":2,"DataCenter":"zone-a","Rack":"2"}
@ ["NameserviceConfig","Node",1,"Location"] # ok
+ {"Body":2,"DataCenter":"default","Rack":"generated-rack-2"}
@ ["NameserviceConfig","Node",0,"WalleLocation"] # ok
- {"Body":1,"DataCenter":"zone-a","Rack":"1"}
@ ["NameserviceConfig","Node",0,"Location"] # ok
+ {"Body":1,"DataCenter":"default","Rack":"generated-rack-1"}
@ ["TableServiceConfig"] # ok
- {"SqlVersion":1}

mirror-3dc-3-nodes-in-memory.yaml.result.json

@ ["ActorSystemConfig"]
- {"BatchExecutor":2,"Executor":[{"Name":"System","SpinThreshold":0,"Threads":2,"Type":"BASIC"},{"Name":"User","SpinThreshold":0,"Threads":3,"Type":"BASIC"},{"Name":"Batch","SpinThreshold":0,"Threads":2,"Type":"BASIC"},{"Name":"IO","Threads":1,"TimePerMailboxMicroSecs":100,"Type":"IO"},{"Name":"IC","SpinThreshold":10,"Threads":1,"TimePerMailboxMicroSecs":100,"Type":"BASIC"}],"IoExecutor":3,"Scheduler":{"ProgressThreshold":10000,"Resolution":256,"SpinThreshold":0},"ServiceExecutor":[{"ExecutorId":4,"ServiceName":"Interconnect"}],"SysExecutor":0,"UserExecutor":1}
@ ["BlobStorageConfig","ServiceSet","PDisks",8,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",7,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",6,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",5,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",4,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",3,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",2,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",1,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",0,"PDiskCategory"]
- 1
@ ["ChannelProfileConfig"]
- {"Profile":[{"Channel":[{"ErasureSpecies":"mirror-3-dc","PDiskCategory":1,"StoragePoolKind":"ssd"},{"ErasureSpecies":"mirror-3-dc","PDiskCategory":1,"StoragePoolKind":"ssd"},{"ErasureSpecies":"mirror-3-dc","PDiskCategory":1,"StoragePoolKind":"ssd"}],"ProfileId":0}]}
@ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"Kind"]
- "ssd"
@ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"PoolConfig","Kind"]
- "ssd"
@ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"PoolConfig","PDiskFilter"]
- [{"Property":[{"Type":"SSD"}]}]
@ ["InterconnectConfig","EncryptionMode"]
+ "OPTIONAL"
@ ["InterconnectConfig","PathToCaFile"]
+ "/opt/ydb/certs/ca.crt"
@ ["InterconnectConfig","PathToCertificateFile"]
+ "/opt/ydb/certs/node.crt"
@ ["InterconnectConfig","PathToPrivateKeyFile"]
+ "/opt/ydb/certs/node.key"
@ ["NameserviceConfig","Node",2,"WalleLocation"]
- {"Body":3,"DataCenter":"3","Rack":"3"}
@ ["NameserviceConfig","Node",2,"Location"]
+ {"Body":3,"DataCenter":"3","Rack":"generated-rack-3"}
@ ["NameserviceConfig","Node",1,"WalleLocation"]
- {"Body":2,"DataCenter":"2","Rack":"2"}
@ ["NameserviceConfig","Node",1,"Location"]
+ {"Body":2,"DataCenter":"2","Rack":"generated-rack-2"}
@ ["NameserviceConfig","Node",0,"WalleLocation"]
- {"Body":1,"DataCenter":"1","Rack":"1"}
@ ["NameserviceConfig","Node",0,"Location"]
+ {"Body":1,"DataCenter":"1","Rack":"generated-rack-1"}
@ ["TableServiceConfig"]
- {"SqlVersion":1}
@ ["GRpcConfig"]
+ {"CA":"/opt/ydb/certs/ca.crt","Cert":"/opt/ydb/certs/node.crt","Key":"/opt/ydb/certs/node.key"}

mirror-3dc-3-nodes.yaml.result.json

@ ["ActorSystemConfig"]
- {"BatchExecutor":2,"Executor":[{"Name":"System","Threads":2,"Type":"BASIC"},{"Name":"User","Threads":3,"Type":"BASIC"},{"Name":"Batch","Threads":2,"Type":"BASIC"},{"Name":"IO","Threads":1,"TimePerMailboxMicroSecs":100,"Type":"IO"},{"Name":"IC","SpinThreshold":10,"Threads":1,"TimePerMailboxMicroSecs":100,"Type":"BASIC"}],"IoExecutor":3,"Scheduler":{"ProgressThreshold":10000,"Resolution":256,"SpinThreshold":0},"ServiceExecutor":[{"ExecutorId":4,"ServiceName":"Interconnect"}],"SysExecutor":0,"UserExecutor":1}
@ ["BlobStorageConfig","ServiceSet","PDisks",8,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",7,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",6,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",5,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",4,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",3,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",2,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",1,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",0,"PDiskCategory"]
- 1
@ ["ChannelProfileConfig"]
- {"Profile":[{"Channel":[{"ErasureSpecies":"mirror-3-dc","PDiskCategory":0,"StoragePoolKind":"ssd"},{"ErasureSpecies":"mirror-3-dc","PDiskCategory":0,"StoragePoolKind":"ssd"},{"ErasureSpecies":"mirror-3-dc","PDiskCategory":0,"StoragePoolKind":"ssd"}],"ProfileId":0}]}
@ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"Kind"]
- "ssd"
@ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"PoolConfig","Kind"]
- "ssd"
@ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"PoolConfig","PDiskFilter"]
- [{"Property":[{"Type":"SSD"}]}]
@ ["GRpcConfig","ServicesEnabled"]
- ["legacy"]
@ ["NameserviceConfig","Node",2,"WalleLocation"]
- {"Body":3,"DataCenter":"zone-c","Rack":"3"}
@ ["NameserviceConfig","Node",2,"Location"]
+ {"Body":3,"DataCenter":"zone-c","Rack":"generated-rack-3"}
@ ["NameserviceConfig","Node",1,"WalleLocation"]
- {"Body":2,"DataCenter":"zone-b","Rack":"2"}
@ ["NameserviceConfig","Node",1,"Location"]
+ {"Body":2,"DataCenter":"zone-b","Rack":"generated-rack-2"}
@ ["NameserviceConfig","Node",0,"WalleLocation"]
- {"Body":1,"DataCenter":"zone-a","Rack":"1"}
@ ["NameserviceConfig","Node",0,"Location"]
+ {"Body":1,"DataCenter":"zone-a","Rack":"generated-rack-1"}
@ ["TableServiceConfig"]
- {"SqlVersion":1}

mirror-3dc-9-nodes.yaml.result.json

@ ["ActorSystemConfig"]
- {"BatchExecutor":2,"Executor":[{"Name":"System","SpinThreshold":0,"Threads":2,"Type":"BASIC"},{"Name":"User","SpinThreshold":0,"Threads":3,"Type":"BASIC"},{"Name":"Batch","SpinThreshold":0,"Threads":2,"Type":"BASIC"},{"Name":"IO","Threads":1,"TimePerMailboxMicroSecs":100,"Type":"IO"},{"Name":"IC","SpinThreshold":10,"Threads":1,"TimePerMailboxMicroSecs":100,"Type":"BASIC"}],"IoExecutor":3,"Scheduler":{"ProgressThreshold":10000,"Resolution":256,"SpinThreshold":0},"ServiceExecutor":[{"ExecutorId":4,"ServiceName":"Interconnect"}],"SysExecutor":0,"UserExecutor":1}
@ ["BlobStorageConfig","ServiceSet","PDisks",8,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",7,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",6,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",5,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",4,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",3,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",2,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",1,"PDiskCategory"]
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",0,"PDiskCategory"]
- 1
@ ["ChannelProfileConfig"]
- {"Profile":[{"Channel":[{"ErasureSpecies":"mirror-3-dc","PDiskCategory":1,"StoragePoolKind":"ssd"},{"ErasureSpecies":"mirror-3-dc","PDiskCategory":1,"StoragePoolKind":"ssd"},{"ErasureSpecies":"mirror-3-dc","PDiskCategory":1,"StoragePoolKind":"ssd"}],"ProfileId":0}]}
@ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"Kind"]
- "ssd"
@ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"PoolConfig","Kind"]
- "ssd"
@ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"PoolConfig","PDiskFilter"]
- [{"Property":[{"Type":"SSD"}]}]
@ ["GRpcConfig","ServicesEnabled"]
- ["legacy"]
@ ["NameserviceConfig","Node",8,"WalleLocation"]
- {"Body":9,"DataCenter":"zone-c","Rack":"9"}
@ ["NameserviceConfig","Node",8,"Location"]
+ {"Body":9,"DataCenter":"zone-c","Rack":"generated-rack-9"}
@ ["NameserviceConfig","Node",7,"WalleLocation"]
- {"Body":8,"DataCenter":"zone-c","Rack":"8"}
@ ["NameserviceConfig","Node",7,"Location"]
+ {"Body":8,"DataCenter":"zone-c","Rack":"generated-rack-8"}
@ ["NameserviceConfig","Node",6,"WalleLocation"]
- {"Body":7,"DataCenter":"zone-c","Rack":"7"}
@ ["NameserviceConfig","Node",6,"Location"]
+ {"Body":7,"DataCenter":"zone-c","Rack":"generated-rack-7"}
@ ["NameserviceConfig","Node",5,"WalleLocation"]
- {"Body":6,"DataCenter":"zone-b","Rack":"6"}
@ ["NameserviceConfig","Node",5,"Location"]
+ {"Body":6,"DataCenter":"zone-b","Rack":"generated-rack-6"}
@ ["NameserviceConfig","Node",4,"WalleLocation"]
- {"Body":5,"DataCenter":"zone-b","Rack":"5"}
@ ["NameserviceConfig","Node",4,"Location"]
+ {"Body":5,"DataCenter":"zone-b","Rack":"generated-rack-5"}
@ ["NameserviceConfig","Node",3,"WalleLocation"]
- {"Body":4,"DataCenter":"zone-b","Rack":"4"}
@ ["NameserviceConfig","Node",3,"Location"]
+ {"Body":4,"DataCenter":"zone-b","Rack":"generated-rack-4"}
@ ["NameserviceConfig","Node",2,"WalleLocation"]
- {"Body":3,"DataCenter":"zone-a","Rack":"3"}
@ ["NameserviceConfig","Node",2,"Location"]
+ {"Body":3,"DataCenter":"zone-a","Rack":"generated-rack-3"}
@ ["NameserviceConfig","Node",1,"WalleLocation"]
- {"Body":2,"DataCenter":"zone-a","Rack":"2"}
@ ["NameserviceConfig","Node",1,"Location"]
+ {"Body":2,"DataCenter":"zone-a","Rack":"generated-rack-2"}
@ ["NameserviceConfig","Node",0,"WalleLocation"]
- {"Body":1,"DataCenter":"zone-a","Rack":"1"}
@ ["NameserviceConfig","Node",0,"Location"]
+ {"Body":1,"DataCenter":"zone-a","Rack":"generated-rack-1"}
@ ["TableServiceConfig"]
- {"SqlVersion":1}

single-node-in-memory.yaml.result.json

@ ["ActorSystemConfig"]
- {"BatchExecutor":2,"Executor":[{"Name":"System","SpinThreshold":0,"Threads":2,"Type":"BASIC"},{"Name":"User","SpinThreshold":0,"Threads":3,"Type":"BASIC"},{"Name":"Batch","SpinThreshold":0,"Threads":2,"Type":"BASIC"},{"Name":"IO","Threads":1,"TimePerMailboxMicroSecs":100,"Type":"IO"},{"Name":"IC","SpinThreshold":10,"Threads":1,"TimePerMailboxMicroSecs":100,"Type":"BASIC"}],"IoExecutor":3,"Scheduler":{"ProgressThreshold":10000,"Resolution":256,"SpinThreshold":0},"ServiceExecutor":[{"ExecutorId":4,"ServiceName":"Interconnect"}],"SysExecutor":0,"UserExecutor":1}
@ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"PoolConfig","Kind"]
- "ssd"
@ ["NameserviceConfig","Node",0,"WalleLocation"]
- {"Body":1,"DataCenter":"1","Rack":"1"}
@ ["NameserviceConfig","Node",0,"Location"]
+ {"Body":1,"DataCenter":"default","Rack":"generated-rack-1"}
@ ["TableServiceConfig"]
- {"SqlVersion":1}
@ ["GRpcConfig"]
+ {"Port":2136}
@ ["MonitoringConfig"]
+ {"MonitoringPort":8765}

single-node-with-file.yaml.result.json

@ ["ActorSystemConfig"]
- {"BatchExecutor":2,"Executor":[{"Name":"System","SpinThreshold":0,"Threads":2,"Type":"BASIC"},{"Name":"User","SpinThreshold":0,"Threads":3,"Type":"BASIC"},{"Name":"Batch","SpinThreshold":0,"Threads":2,"Type":"BASIC"},{"Name":"IO","Threads":1,"TimePerMailboxMicroSecs":100,"Type":"IO"},{"Name":"IC","SpinThreshold":10,"Threads":1,"TimePerMailboxMicroSecs":100,"Type":"BASIC"}],"IoExecutor":3,"Scheduler":{"ProgressThreshold":10000,"Resolution":256,"SpinThreshold":0},"ServiceExecutor":[{"ExecutorId":4,"ServiceName":"Interconnect"}],"SysExecutor":0,"UserExecutor":1}
@ ["BlobStorageConfig","ServiceSet","PDisks",0,"Path"]
- "/tmp/pdisk.data"
+ "/tmp/ydb.data"
@ ["ChannelProfileConfig","Profile",0,"Channel",2,"PDiskCategory"]
- 0
+ 1
@ ["ChannelProfileConfig","Profile",0,"Channel",1,"PDiskCategory"]
- 0
+ 1
@ ["ChannelProfileConfig","Profile",0,"Channel",0,"PDiskCategory"]
- 0
+ 1
@ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"PoolConfig","Kind"]
- "ssd"
@ ["NameserviceConfig","Node",0,"WalleLocation"]
- {"Body":1,"DataCenter":"1","Rack":"1"}
@ ["NameserviceConfig","Node",0,"Location"]
+ {"Body":1,"DataCenter":"default","Rack":"generated-rack-1"}
@ ["TableServiceConfig"]
- {"SqlVersion":1}
@ ["GRpcConfig"]
+ {"Port":2136}
@ ["MonitoringConfig"]
+ {"MonitoringPort":8765}

Enjection avatar Feb 15 '24 11:02 Enjection

:white_circle: 2024-02-16 11:56:48 UTC Pre-commit check for 824f25099ff116a93708bfb652f827133b909373 has started. :white_circle: 2024-02-16 11:56:50 UTC Build linux-x86_64-relwithdebinfo is running... :green_circle: 2024-02-16 11:59:18 UTC Build successful. :white_circle: 2024-02-16 11:59:32 UTC Tests are running... :red_circle: 2024-02-16 13:40:07 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67533 56494 0 25 10984 30

github-actions[bot] avatar Feb 16 '24 11:02 github-actions[bot]

Updated after extracting dependent PRs #1990 and #1973

Enjection avatar Feb 16 '24 11:02 Enjection

:white_circle: 2024-02-16 11:57:35 UTC Pre-commit check for 824f25099ff116a93708bfb652f827133b909373 has started. :white_circle: 2024-02-16 11:57:36 UTC Build linux-x86_64-release-asan is running... :green_circle: 2024-02-16 11:59:49 UTC Build successful. :white_circle: 2024-02-16 11:59:57 UTC Tests are running... :red_circle: 2024-02-16 13:41:54 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14769 14580 0 24 129 36

github-actions[bot] avatar Feb 16 '24 11:02 github-actions[bot]

Maybe a part of the diff above is not an issue. I just found that later in transformation pipeline in driver_lib we set up DummyActorSystemConfig, so, I will check the behavior and write it here later.

Enjection avatar Feb 17 '24 10:02 Enjection

Maybe a part of the diff above is not an issue. I just found that later in transformation pipeline in driver_lib we set up DummyActorSystemConfig, so, I will check the behavior and write it here later.

@Enjection yes, dropped actor system config was intended: last year the automatic actor system configuration mode has been introduced and this example was written before that.

Similarly for TableServiceConfig.SqlVersion it should be the default now.

blinkov avatar Feb 20 '24 06:02 blinkov

Maybe a part of the diff above is not an issue. I just found that later in transformation pipeline in driver_lib we set up DummyActorSystemConfig, so, I will check the behavior and write it here later.

@Enjection yes, dropped actor system config was intended: last year the automatic actor system configuration mode has been introduced and this example was written before that.

Similarly for TableServiceConfig.SqlVersion it should be the default now.

@blinkov good. I additionaly asked kruall@ about AS config and he told me almost the same about it. There are still some caveats with auto AS config, but seems that it doesn't matter for these specific configs. I will check remaining fields this evening, and probably merge this PR.

Enjection avatar Feb 20 '24 09:02 Enjection

Okay, I still have some doubts about these changes. Especially about next ones. I have to double check that it won't break anything.

@ ["BlobStorageConfig","ServiceSet","PDisks",7,"PDiskCategory"] # suspicios
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",6,"PDiskCategory"] # suspicios
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",5,"PDiskCategory"] # suspicios
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",4,"PDiskCategory"] # suspicios
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",3,"PDiskCategory"] # suspicios
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",2,"PDiskCategory"] # suspicios
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",1,"PDiskCategory"] # suspicios
- 1
@ ["BlobStorageConfig","ServiceSet","PDisks",0,"PDiskCategory"] # suspicios
- 1
@ ["ChannelProfileConfig"] # suspicios
- {"Profile":[{"Channel":[{"ErasureSpecies":"block-4-2","PDiskCategory":1,"StoragePoolKind":"ssd"},{"ErasureSpecies":"block-4-2","PDiskCategory":1,"StoragePoolKind":"ssd"},{"ErasureSpecies":"block-4-2","PDiskCategory":1,"StoragePoolKind":"ssd"}],"ProfileId":0}]}
@ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"Kind"] # suspicios
- "ssd"
@ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"PoolConfig","Kind"] # suspicios
- "ssd"
@ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"PoolConfig","PDiskFilter"] # suspicios
- [{"Property":[{"Type":"SSD"}]}]
@ ["GRpcConfig","ServicesEnabled"] # error
- ["legacy"]

Enjection avatar Feb 27 '24 08:02 Enjection

So, alexvru@ told that we probably shouldn't remove PDiskCategory, because in this case we may get ROT behaviour instead of SSD And

@ ["DomainsConfig","Domain",0,"StoragePoolTypes",0,"PoolConfig","PDiskFilter"]

also critically important

Enjection avatar Feb 27 '24 09:02 Enjection

:white_circle: 2024-02-27 09:14:12 UTC Pre-commit check for 5be921b827a2fe3d6e6e928c477afc76dc4582a8 has started. :white_circle: 2024-02-27 09:14:13 UTC Build linux-x86_64-release-asan is running... :green_circle: 2024-02-27 09:16:01 UTC Build successful. :white_circle: 2024-02-27 09:16:12 UTC Tests are running... :red_circle: 2024-02-27 10:57:02 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14863 14721 0 19 97 26

github-actions[bot] avatar Feb 27 '24 09:02 github-actions[bot]

The same for legacy service -- we can't disable it. Storage just won't start.

Enjection avatar Feb 27 '24 09:02 Enjection

@blinkov What do you think?

Enjection avatar Feb 27 '24 09:02 Enjection

:white_circle: 2024-02-27 09:37:05 UTC Pre-commit check for 5be921b827a2fe3d6e6e928c477afc76dc4582a8 has started. :white_circle: 2024-02-27 09:37:06 UTC Build linux-x86_64-relwithdebinfo is running... :green_circle: 2024-02-27 09:38:52 UTC Build successful. :white_circle: 2024-02-27 09:39:00 UTC Tests are running... :red_circle: 2024-02-27 10:55:58 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67860 56945 0 3 10883 29

github-actions[bot] avatar Feb 27 '24 09:02 github-actions[bot]

:white_circle: 2024-02-27 11:30:14 UTC Pre-commit check for 5be921b827a2fe3d6e6e928c477afc76dc4582a8 has started. :white_circle: 2024-02-27 11:30:16 UTC Build linux-x86_64-release-cmake14 is running... :green_circle: 2024-02-27 11:33:47 UTC Build successful.

github-actions[bot] avatar Feb 27 '24 11:02 github-actions[bot]

:white_circle: 2024-03-20 06:33:00 UTC Pre-commit check for 148ef6d25a6eec000cc70bb79c176758bee7c4e2 has started. :white_circle: 2024-03-20 06:33:02 UTC Build linux-x86_64-release-clang14 is running... :red_circle: 2024-03-20 06:34:47 UTC Build failed. see the build logs.

github-actions[bot] avatar Mar 20 '24 06:03 github-actions[bot]

:white_circle: 2024-03-20 06:33:08 UTC Pre-commit check for 148ef6d25a6eec000cc70bb79c176758bee7c4e2 has started. :white_circle: 2024-03-20 06:33:11 UTC Build linux-x86_64-release-asan is running... :red_circle: 2024-03-20 06:35:01 UTC Build failed. see the build logs. :red_circle: 2024-03-20 06:35:03 UTC Tests run skipped.

github-actions[bot] avatar Mar 20 '24 06:03 github-actions[bot]

:white_circle: 2024-03-20 06:33:16 UTC Pre-commit check for 148ef6d25a6eec000cc70bb79c176758bee7c4e2 has started. :white_circle: 2024-03-20 06:33:19 UTC Build linux-x86_64-relwithdebinfo is running... :red_circle: 2024-03-20 06:35:14 UTC Build failed. see the build logs. :red_circle: 2024-03-20 06:35:16 UTC Tests run skipped.

github-actions[bot] avatar Mar 20 '24 06:03 github-actions[bot]

:white_circle: 2024-03-22 20:45:10 UTC Pre-commit check for 355feafbce479e05687698c05e2b29afdfd156a2 has started. :white_circle: 2024-03-22 20:45:13 UTC Build linux-x86_64-release-asan is running... :red_circle: 2024-03-22 20:47:10 UTC Build failed. see the build logs. :red_circle: 2024-03-22 20:47:11 UTC Tests run skipped.

github-actions[bot] avatar Mar 22 '24 20:03 github-actions[bot]

:white_circle: 2024-03-22 20:46:08 UTC Pre-commit check for 355feafbce479e05687698c05e2b29afdfd156a2 has started. :white_circle: 2024-03-22 20:46:10 UTC Build linux-x86_64-release-clang14 is running... :red_circle: 2024-03-22 20:48:05 UTC Build failed. see the build logs.

github-actions[bot] avatar Mar 22 '24 20:03 github-actions[bot]

:white_circle: 2024-03-22 20:46:09 UTC Pre-commit check for 355feafbce479e05687698c05e2b29afdfd156a2 has started. :white_circle: 2024-03-22 20:46:11 UTC Build linux-x86_64-relwithdebinfo is running... :red_circle: 2024-03-22 20:48:09 UTC Build failed. see the build logs. :red_circle: 2024-03-22 20:48:10 UTC Tests run skipped.

github-actions[bot] avatar Mar 22 '24 20:03 github-actions[bot]

:white_circle: 2024-03-23 12:39:14 UTC Pre-commit check for 2df25817676112ffe6f86be9597d11831c1e20ec has started. :white_circle: 2024-03-23 12:39:16 UTC Build linux-x86_64-release-clang14 is running... :black_circle: 2024-03-23 12:41:15 UTC Check cancelled

github-actions[bot] avatar Mar 23 '24 12:03 github-actions[bot]

:white_circle: 2024-03-23 12:39:23 UTC Pre-commit check for 2df25817676112ffe6f86be9597d11831c1e20ec has started. :white_circle: 2024-03-23 12:39:27 UTC Build linux-x86_64-release-asan is running... :green_circle: 2024-03-23 12:40:55 UTC Build successful. :black_circle: 2024-03-23 12:41:02 UTC Check cancelled

github-actions[bot] avatar Mar 23 '24 12:03 github-actions[bot]

:white_circle: 2024-03-23 12:39:36 UTC Pre-commit check for 2df25817676112ffe6f86be9597d11831c1e20ec has started. :white_circle: 2024-03-23 12:39:38 UTC Build linux-x86_64-relwithdebinfo is running... :green_circle: 2024-03-23 12:41:00 UTC Build successful. :black_circle: 2024-03-23 12:41:01 UTC Check cancelled

github-actions[bot] avatar Mar 23 '24 12:03 github-actions[bot]

:white_circle: 2024-03-23 12:42:20 UTC Pre-commit check for 748a2b7ae3466473f7990afba327972c609bc94c has started. :white_circle: 2024-03-23 12:42:22 UTC Build linux-x86_64-relwithdebinfo is running... :green_circle: 2024-03-23 12:43:19 UTC Build successful. :white_circle: 2024-03-23 12:43:38 UTC Tests are running... :red_circle: 2024-03-23 14:03:20 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69038 57927 0 8 11026 77

github-actions[bot] avatar Mar 23 '24 12:03 github-actions[bot]

:white_circle: 2024-03-23 12:42:20 UTC Pre-commit check for 748a2b7ae3466473f7990afba327972c609bc94c has started. :white_circle: 2024-03-23 12:42:22 UTC Build linux-x86_64-release-clang14 is running... :green_circle: 2024-03-23 12:55:30 UTC Build successful.

github-actions[bot] avatar Mar 23 '24 12:03 github-actions[bot]

:white_circle: 2024-03-23 12:44:29 UTC Pre-commit check for 748a2b7ae3466473f7990afba327972c609bc94c has started. :white_circle: 2024-03-23 12:44:32 UTC Build linux-x86_64-release-asan is running... :green_circle: 2024-03-23 12:45:39 UTC Build successful. :white_circle: 2024-03-23 12:46:00 UTC Tests are running... :red_circle: 2024-03-23 14:39:32 UTC Test run completed, no test results found for commit 90dcc2eb5b8f34583207a765dc81df9c6bc16124. Please check build logs. :black_circle: 2024-03-23 14:39:35 UTC Check cancelled

github-actions[bot] avatar Mar 23 '24 12:03 github-actions[bot]

:white_circle: 2024-03-23 14:42:50 UTC Pre-commit check for 766e5a7595e8b4dfbbb7868b4308cd969163c49b has started. :white_circle: 2024-03-23 14:42:53 UTC Build linux-x86_64-release-clang14 is running... :green_circle: 2024-03-23 14:44:01 UTC Build successful.

github-actions[bot] avatar Mar 23 '24 14:03 github-actions[bot]

:white_circle: 2024-03-23 14:42:58 UTC Pre-commit check for 766e5a7595e8b4dfbbb7868b4308cd969163c49b has started. :white_circle: 2024-03-23 14:43:01 UTC Build linux-x86_64-release-asan is running... :green_circle: 2024-03-23 14:44:11 UTC Build successful. :white_circle: 2024-03-23 14:44:31 UTC Tests are running... :red_circle: 2024-03-23 14:55:47 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15152 14503 0 79 537 33

github-actions[bot] avatar Mar 23 '24 14:03 github-actions[bot]