Eduardo Pinho

Results 343 comments of Eduardo Pinho

> I think this will conflict with #598 i just created earlier today If it helps create some coordination, we can decide an order of contribution merges so that we...

Hello again! Feel free to let me know if you need assistance reviving this pull request, or if you would like someone else to take over.

I just tried building another project of mine against the latest nightly with `unstable-provider-api` and it also failed in deriving `Snafu` for an error enum with a whatever variant. Likewise,...

> All I wanted was backtraces on errors that escaped main(). The points made so far seem to suggest that you would be better served with `anyhow` or `eyre`. At...

> One option to handle potentially misaligned inputs is to allocate a temporary `Vec` and copy the provided data into it. That adds some memory overhead, but should be pretty...

This has been rebased and the previous concerns have been addressed, so it is ready for another review. I cannot inspect the logs of the failing CI checks.

You are right, there is a rather tight connection between the encoder and the write destination at the moment. This is also the case for decoders, with its own set...

Thank you for reporting. We can work towards the correctness of `PartialEq`, though its usage in practice is primarily for testing. Would you be able to create a minimal example...

> I'd like to ask: What is the logic behind not writing a DataToken::ItemEnd or SequenceEnd ? I just followed [Part 5 section 7.5](https://dicom.nema.org/medical/dicom/current/output/chtml/part05/sect_7.5.html). The encoder can choose either one...

> But both DCMTK and Pydicom recalculate the original Explicit Length, dicom-rs leaves it as is, this produces a lot of decoding bugs in the very same file. All can...