Eduardo Pinho comments

Results 343 comments of


                                            Eduardo Pinho

First crack at adding dataset read adapter in DS read for deflate

We're ready to merge this. Thanks again @naterichman. :muscle:

Introduce constructor functions to improve ergonomics of creating error contexts

In the first example, the idiomatic form of creating context is this. ```rust self.id.to_string().parse().context(ParseStrategyKindSnafu { strategy_id: self.id, }) ``` (For this to work you need to rename the field `error`...

Introduce constructor functions to improve ergonomics of creating error contexts

In that failing example you seem to be using `String` as an error in `::Err`. Prefer a new custom error type, or a `WhateverError` which also accepts an arbitrary message....

Introduce constructor functions to improve ergonomics of creating error contexts

One other problem I am seeing with this proposal is that the methods `build` and `fail` already exist, so the new associated functions would have to be named something else....

Introduce constructor functions to improve ergonomics of creating error contexts

> @Enet4 `String` Error common case in third party dependencies That may then be a case for #103. In the meantime, if possible, one can suggest the third party dependency...

Failure when Explicit VR contains Implicit VR

Thank you for reporting. Can you validate that this is a duplicate of https://github.com/Enet4/dicom-rs/issues/169? It's a rare scenario, but it's true that the parser currently misbehaves when entering nested sequences...

Failure when Explicit VR contains Implicit VR

So I see. This is something else all right! It should be fine to introduce some simple logic there if it helps read that file to completion.

[core] Make `PersonName` hold both borrowed and owned strings

Hello @AlexTMjugador! That is an interesting idea, but I wonder whether we can introduce this without a semver breaking change. Extending the owned version of a person name into a...

[core] Make `PersonName` hold both borrowed and owned strings

Fair enough, this can added to the 0.9 milestone.

No apparent way to have an error enum variant documentation generated from a display string

> which implicitly appends the source to the doc string error to create the display That would be ill advised as per the [recommendations from the error handling WG](https://github.com/rust-lang/project-error-handling/issues/27#issuecomment-763950178). If...