Eduardo Pinho

Results 343 comments of Eduardo Pinho

Other than the comment above, I don't see any major issues so far. I'd say we take care of the PRs over at `charls-rs` - https://github.com/coradoya/charls-rs/pull/1 - https://github.com/coradoya/charls-rs/pull/2 And after...

Much appreciated! > I've been doing some more reading up, and unfortunately it seems like the options are > > 1. Repeat a bunch of code either manually or with...

> Let me make sure I'm understanding where you're going. For the reader implementation, it would be something like: > > * Rename `read_pdu` to something like `parse_pdu` and leave...

> What kind of trait bound might be better, something like `Buf` or `BufMut`? At that point why not just make `read_pdu` take `&mut BytesMut` or `Cursor`. Both `BytesMut` and...

Thank you for your commitment @naterichman. I haven't had much free time to work on DICOM-rs last month, but I'm looking forward to getting more contributions rolling this month. Is...

> Hi @Enet4, was strange, it was only in beta and it has now gone away... Oh yes, it was likely a bad rustc lint in beta (#564), which has...

> Where are those files you were testing on? I'd like to see if I can reproduce using that file, or maybe its because you are on windows and there...

I would have greatly wished to merge this, but right now the transfer goes wrong whenever the `concurrency` option in `dicom-storescu` is set, even when I set it to 1....

Thank you for reporting, that makes sense. Let me know if you need assistance.

Thank you for reporting. That does seem a little bit too intense for decoding. Maybe the amount of parallelism can be reduced through environment variables or build parameters, but I...