Eduardo Pinho

Results 254 comments of Eduardo Pinho

> But shouldn't the transpose then be conditional on `is_standard_layout()`(https://docs.rs/ndarray/latest/ndarray/struct.ArrayBase.html#method.is_standard_layout) The code may be under an assumption that the ndarray provided is always in C contiguous order. I cannot quite...

The [C-GOOD-ERR](https://rust-lang-nursery.github.io/api-guidelines/interoperability.html#error-types-are-meaningful-and-well-behaved-c-good-err)) API guideline from the Rust API guidelines states that "Error types should be meaningful and well-behaved". If an error type does not implement `std::error::Error`, it will not be...

@bvssvni I was looking for the concrete `GlyphCache` implementation, but the documentation would direct me to a broken link. Thanks! I also found a related issue: gfx-rs/gfx#506

It appears to be a niche concept, but so are some of the other entries in the repository. If you'd like to send in a PR, I'd be glad to...

Hello! Thank you for your interest in DICOM-rs. There are no plans for it, but it would very likely have a place in the project if someone takes initiative. If...

It should hopefully not be too overwhelming if you have the DICOM part covered. I would advise taking `dicom-storescu` as a baseline and change the DIMSE interactions from there.

Interesting catch. I agree that it should also disallow PDUs larger than that when in strict mode. I wonder if passing it to `ServerAssociationOptions` is enough.

Thank you for the initiative, @jennydaman. Going async for DICOM network operations is unquestionably the way forward for the project. > I have identified `FileDicomObj::write_to_file` and the `TcpStream` accepting methods...

Thank you for reporting. This might have to do with the use of a hash set to keep track of the presentation contexts to propose, in line 134. ```rust let...

> That could be it! Though I shouldn't be making a PR about this yet. I myself am not fluent in DICOM and I am not sure which is correct...