Benjamin Woosley

Results 50 comments of Benjamin Woosley
trafficstars

I think I've got it, as of last night. I'll put together a fork of the rails example app adjusted to work with my changes. The basic flow is this:...

Alright, I have the fixes up at: http://github.com/Empact/authlogic_rpx http://github.com/Empact/rails-authlogic-rpx-sample One change which ought to be scrutinized & discussed is that it was necessary to monkey-patch authlogic to remove the save_record...

I'm still unsure about the authlogic valid? monkey patch. We should look at how the authlogic_openid plugin handles auto-reg, as I believe it has binarylogic's involvement.

I have mixed feelings about this, as it seems to be oriented toward social network presence, so it favors e.g. podcasters and personalities.

> So perhaps it would be better to change this function to return true after emitting the warning. Well thanks for testing - in this case we don't need to...

Disabled the warning on `fReindexChainState`, and reworked it to avoid duplicative check in the cases where `additional_bytes_needed` would be 0.

Moved the check further down initialization, to the point where `chain_active_height` was already being read, so we don't need to do any new locking - a question to test is:...

As suggested, moved the check back to being alongside the other disk space checks.

Will need some accommodation for the tests - ignoring the message perhaps?: > test 2022-08-08T06:47:18.274000Z TestFramework (ERROR): Assertion failed Traceback (most recent call last): File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 133, in main...

@promag Addressed your comments, including tests for each case.