Benjamin Woosley
Benjamin Woosley
My inclination would be to fix the `-Wshadow` warnings over the course of several PRs (to ease review/minimize conflicts), then add the warning to one of the CI runs to...
I have some questions about this change, but to start I would encourage you to make the change a minimal one. I.e. avoid strictly unnecessary changes, such as those in...
@paplorinc agree with @fanquake, a better place to articulate your motivations and reasoning is in the commit messages, that way they'll be retained for future reference via `git blame`, etc.
I relaxed the hashie requirement here: 96e1a559624756a82cb1a33f35b5546ff1152a8a Could you install from the repo and check if this is still a problem for you?
Done - note I haven't tested this recently so would be good to test it out!
Hi there, I'm not the original author, I just put it up on github for my own purposes. If you'd like to help maintain the library, feel free to do...
Would be nice to structure this as a [scripted diff](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#scripted-diffs): one commit where you add the function and requires, another where you convert the `assert !=`s. That would ensure programmatically...
Fyi the current uses of `__APPLE__` in the codebase are from external libs included directly into the codebase as subtrees, see `get_subtrees` for a list of the related dirs. `tinyformat.h`...
I'm +0 on this change but not particularly familiar with the scope and variety of our Apple-related builds.