HAO YAN

Results 14 comments of HAO YAN

I think that PR (forgotten to fix the PR >.

> Are those treasure chest seen by all players or players who used the item? No idea, I am curious too but I didnt found any info regarding this.

I have no idea how to do the `OPTION_CLOAK` trick, maybe I shalll leave it to any of you who familiar to do it in future or push any new...

@4144 is there any advise for me to do it? the validation for npc name length has been done prior to this. append `targetname` with `\0` ?

It's a QoL changes. Just like `item_combo` file which use the constants and not item ID. It would be useful for other server that has alot of custom changes on...

for case-sensitivity may refer @MishimaHaruna's https://github.com/HerculesWS/Hercules/issues/685#issuecomment-136308412 for reference.

btw, why prefer to have new `getitem3` `delitem3` and etc? why not just consider the existing `getitem2` `delitem2` and etc as option? just make those new fields as optional field?

> So I'm good with this, but maybe the script name could use some loving? Something like `plagiarizeskill` and `plagiarizeskillreset`. I would prefer the previous name since its easier to...