Enable *plagiarism script commands

[Emistry]

• Addressed Issue(s): unable to control the plagiarism skill using npc

• Server Mode: both

• Description of Pull Request: enable to use script command to control skill plagiarism if needed. enable player to copy or erase skill using NPC

[Emistry]

updated and rebased.

[aleos89]

So I'm good with this, but maybe the script name could use some loving? Something like plagiarizeskill and plagiarizeskillreset.

[Emistry]

So I'm good with this, but maybe the script name could use some loving? Something like plagiarizeskill and plagiarizeskillreset.

I would prefer the previous name since its easier to read, anyway updated it to plagiarizeskill and plagiarizeskillreset

[aleos89]

You can also set the alias if you'd like, so that we have both names available! I see no harm in that as long as both are documented in the script_commands. 👍🏼

[Emistry]

is okay, keep one is enough, wont take long to get used to it.

[Emistry]

I dont understand this new changes.. previously we use *sd, but now all change to &sd ? but still alot place using *sd ?

[Lemongrass3110]

I dont understand this new changes.. previously we use *sd, but now all change to &sd ? but still alot place using *sd ?

@Emistry we use reference wherever possible now, as it does not allow nullpointers. We did not want to change everything at once, so we do it slowly whenever we touch something and we also do it when we add new things.

[lgtm-com[bot]]

This pull request introduces 1 alert when merging 6d8f66a73fd1f74517ffb03ec424815731995778 into 47c9a362156b27fca484fd70e7990ceb1cc79d32 - view on LGTM.com

new alerts:

• 1 for Too few arguments to formatting function

[gidzdlcrz]

I tried to manually diff this. No error when compiling but it doesn't work. Does it have pre requisite commits?

[Akkarinage]

I tried to manually diff this. No error when compiling but it doesn't work. Does it have pre requisite commits?

This is already merged to master - it's been in our codebase for 18 months.. update your rAthena.