Máximo Mussini

Results 129 comments of Máximo Mussini

@bensheldon I believe that the missing piece is that when overriding the `initialize` method in the `GoodJob::ActiveJobExtensions::Labels` module, it should use [`ruby2_keywords(:initialize)`](https://github.com/rails/rails/blob/main/activejob/lib/active_job/core.rb#L103), otherwise by the time the arguments reach `activejob`,...

Hi Aaron, thanks for reporting. Can you confirm if the following patch fixes the issue in your scenario: ```ruby ViteRuby::Manifest.prepend Module.new { # Internal: Prefixes an asset with the `asset_host`...

[`define`](https://vitejs.dev/config/shared-options.html#define) is still supported in Vite 5. I've updated the test setup to run with Vite 5, and tests continue to pass. Please provide a minimal example that used to...

Sorry, accidentally hit close with comment.

@pepa-linha Created [vite-plugin-manifest-sri], which might be useful for your use case. [vite-plugin-manifest-sri]: https://github.com/ElMassimo/vite-plugin-manifest-sri

@TimJohns I'm not sure [`vite-plugin-manifest-sri`](https://github.com/ElMassimo/vite-plugin-manifest-sri) is susceptible to the problem you mentioned, as it uses [`writeBundle`](https://rollupjs.org/plugin-development/#writebundle) which is "the last hook of the output generation phase". However, this plugin is...

> per-action conditional sharing I think the appeal of `inertia_share` is for things you'll need on every request, like `flash` or `current_user`, otherwise it starts to become difficult to understand...

Hi Ahmed! Appreciate you sharing this pull request. Regarding the ESLint config, I'd be ok using something like `@antfu/eslint-config` and tweak a few rules which align more with standardjs. For...

Hi @TechAkayy! Would you enable me to push updates to this branch in your fork?

@TechAkayy Thanks again for diving into this! I've completed the upgrades in #281, and the CI is green once again. I've cherry-picked the last 3 commits here and moved them...