Efnilite
Efnilite
> Can this just be put into the already existing CanSee condition and PlayerVisibility effect instead of making brand new ones? Not sure about that, since the entity one has...
> what's the status of the junit tests? i think the EffEntityVisibility test is fine, but not really sure how to improve the one for CondCanSee. maybe adding an entity...
@sovdeeth should be good now
> Looks good, the only thing missing is some tests! This would need JUnit tests, so if you're not comfortable with adding those, please let me know and I can...
> > > Looks good, the only thing missing is some tests! This would need JUnit tests, so if you're not comfortable with adding those, please let me know and...
> Your expressions aren't gated behind class exists checks which expressions in which file do you mean? in the java file i have this rn https://github.com/SkriptLang/Skript/blob/cb4f148c441180071bf7f3412299a5fb2dc22ab1/src/test/java/org/skriptlang/skript/test/tests/syntaxes/events/EvtPiglinBarterTest.java#L47
Aight, should be good now
good luck :)
> There’s `event-location` in tests > > https://github.com/SkriptLang/Skript/blob/ba32d7ad48edb8e33d5f5d2e44d03bba94ffb2de/src/main/java/ch/njol/skript/test/runner/EvtTestCase.java#L45-L59 this is used in like 5 tests, also `test-location` looks nicer :)
@UnderscoreTud the event can only be called asynchronously, but it seems that this causes it to not complete the objectives as the event is called after the tests have completed,...