Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Update ExprHoverList for 1.21+

Open Efnilite opened this issue 1 year ago • 2 comments

Description

Fixes #6974 while maintaining backwards compatibility. Tested on 1.20.5 and 1.21.1 with the code used in the original issue. Not sure how I would add tests for this, please lmk for ideas.


Target Minecraft Versions: any Requirements: none Related Issues: #6974

Efnilite avatar Aug 20 '24 19:08 Efnilite

@UnderscoreTud the event can only be called asynchronously, but it seems that this causes it to not complete the objectives as the event is called after the tests have completed, therefore saying that no objectives have been completed, despite the fact that they do actually complete. i've also had to do some trickery to make sure it recognizes it as the current test. any ideas on how to fix this?

Efnilite avatar Aug 22 '24 14:08 Efnilite

before this is merged, https://github.com/SkriptLang/Skript/pull/6988#issuecomment-2304811563 needs to be addressed by someone who actually knows what they're doing

Efnilite avatar Aug 27 '24 18:08 Efnilite

I think it'd be better to simply remove the tests if we can't find a quick fix rather than put this off till 2.9.3

sovdeeth avatar Aug 31 '24 20:08 sovdeeth