Edoardo Abati
Edoardo Abati
Hi @cmarmo , thank you very much for the fast review. docs should be updated now! :)
Hi @glemaitre thank you very much for your review! :) I will work on your proposed changes next week, if it's ok.
Hi @glemaitre I finally had time to have a look at this, and I remembered why I did not update `BaseEnsemble`. There is `BaseWeightBoosting` that inherits from it, and there...
Hi @glemaitre , I have made the deprecation from `BaseEnsemble`, please let me know if this is what you had in mind or if I misunderstood :) With this implementation,...
Hi @glemaitre , I should have implemented (hopefully) what you asked. Please let me know if it is in the direction of what you had in mind. :) There are...
Oh yes, that was a silly oversight on my side. Thank you for fixing it! And thank you again very much for reviewing, a couple of minor things maybe still...
@glemaitre , thank you very much! :) I will pull this one. I may be wrong, but probably we should add a couple of things to the `_parameter_constraints` in estimator...
@glemaitre I think I added all your suggestion :)
Thank you very much @glemaitre for the help. :) And apologies for the long back-and-forth, I got a bit confused on what needed to be done. (I hope I didn't...
Hi @jeremiedbb , thank you for the review! I should have addressed everything. I have added a fix to the documentation of `[RandomTreesEmbedding` [2cd0cf2](https://github.com/scikit-learn/scikit-learn/pull/23819/commits/2cd0cf22b74995122b109fde9f83afd7d4aac13e). The docstring said that the estimator...