Edoardo Abati
Edoardo Abati
Hi @lewtun , apologies for the ping. Not sure if you saw this PR :)
No problem at all @TamaraAtanasoska :) I changed the base branch to `main` to make the review easier then. Let me know if I should switch back to the integration...
Apologies for the delay, but I finally found time to address the comments! 😄 Thank you for the review everyone, please let me know if there is anything else that...
This PR diff is getting big because of all the `xfail` in tests. 😕 @MarcoGorelli @FBruzzesi do you have a better idea on how to make it more "reviewable"? or...
This is finally ready for review 🥵 I have to fix the tests on windows (I think I may need to set up Java or something similar) and the test...
@MarcoGorelli @FBruzzesi which criteria did we use to decide the minimal supported versions? Popularity? Time of release?
Because of `pyspark` current requirements, trying to make all the tests pass is a bit tricky. I decided to make `3.3.0` the minimum dependency, the most recent version is `3.5.2`....
I think it is because of a new warning introduced yesterday in `polars==1.14` [source](https://github.com/pola-rs/polars/releases/tag/py-1.14.0). I need to check if we import polars in any code triggered by the spark workers...
Tests are green (a part from an unrelated one) Please let me know if you or @FBruzzesi have any other questions or ideas how to improve this :) I think...
Thank you all for the feedback and apologies this is taking longer but I am a bit busy. The CI is _almost_ green 😅 I need to add some if-else...