Edoardo Zoni
Edoardo Zoni
Regarding the PML test, I wonder how much the absolute tolerance `tolerance_abs = 2.`, which is set empirically in the analysis, is expected to change, itself, due to the different...
@NeilZaim I think I agree with Dave here. Since the issue you observed is related to standard PSATD only, let's fix it step by step. We can try to keep...
I pushed a few commits to update this old branch and see if we can still get these changes to work.
@Yin-YinjianZhao @RemiLehe Would you be able to point to the lines in the Smilei code where the Higginson correction is implemented? Is it supposed to be found somewhere in their...
@RevathiJambunathan @roelof-groenewald I added you as reviewers of this PR as well, since you did extensive work on PEC boundary conditions in WarpX in the past.
@dpgrote Sorry that this got stalled for so long. I was waiting for feedback from other developers on some of the questions I asked in my review, but if this...
Just another note on this, the options `CALL_GRAPH` and `CALLER_GRAPH` of Doxygen, currently set to `NO` in our Docs/Doxyfile, https://github.com/BLAST-WarpX/warpx/blob/63e032b158cada62a4c4d11e9f22384da00fc55c/Docs/Doxyfile#L2545-L2567 and/or the commands `\callgraph`/`\callergraph` or `\hidecallgraph`/`\hidecallergraph` to add or hide...
@JustinRayAngus This PR is not modifying anything related to CI, so it may be some sort of random glitch. I restarted the failed checks just to see if the issue...
@JustinRayAngus Got it, thanks. Very strange, though. If we look at that step in the workflow, https://github.com/BLAST-WarpX/warpx/blob/b4009ed9944ef4262140d1afb498573823c24352/.azure-pipelines.yml#L134-L150 we set `set -o nounset errexit pipefail` precisely to avoid a situation where...
@lucafedeli88 @dpgrote I will try to go through each of your comments and see if there is a corresponding option that can be set to match your suggestions. However, I'm...