Edoardo Zoni
Edoardo Zoni
Thank you for this PR, @aeriforme! I have a couple of quick comments first: - I see a file `.vscode/settings.json` that looks like a config file pushed by accident. I...
Also, I think the CodeQL alerts need to be addressed, too. Not all of them are always relevant, but it is still good to double check and remove as many...
Discussed with @RemiLehe: need to check if there is any overlap with the changes proposed in #4125 by @roelof-groenewald.
Putting "[WIP]" back in the PR title, waiting for CI to run and catch all instances of `none` to be replaced.
@aeriforme @JustinRayAngus I found this while looking at the list of PRs that are not labeled as "WIP" and it looks to me like this could be good material for...
@ax3l Would it be possible for you to fix the conflict in cmake/dependencies/AMReX.cmake before others start pushing local commits here? I can try to fix that as well, if needed....
@RemiLehe I was assigned to this one, so I went ahead and rebased on `development`. I also removed the member function `clear` from the class `InjectorMomentum` since it seemed to...
The CI test `Python_gaussian_beam` fails because the corresponding PICMI script attempts to initialize an electron beam with a Gaussian distribution that includes radial expansion (non-zero `velocity_divergence`): https://github.com/ECP-WarpX/WarpX/blob/eaf0e0d1965e7c97560ea4bf71c9a5623a577732/Examples/Tests/gaussian_beam/PICMI_inputs_gaussian_beam.py#L54-L56 Would you know...
@RemiLehe Hi Remi, I saw this PR here and was wondering if it's worth trying to finalize it? It seems like it could lead to a small optimization, since it's...
@dpgrote @NeilZaim For the Galilean tests, I think Dave's point is a good one. In Cartesian geometry, we set `update_with_rho` to `true` by default for Galilean PSATD because we had...