Andrei Zavatski

Results 22 issues of Andrei Zavatski

To make things easy to review this pr brings only basic shader implementation, smoothening will come in a separate pr. ~~Also I'm not sure so I'll ask here: do we...

blocked
area:graphics
size/L

In osu-side min value for this sound is 20 but currently there's no way to override it.

osu-side fix required

These values have been taken during beatmap loading (going from song-select to player loader and waiting until player screen push) |master|pr| |---|---| |![master-loading](https://github.com/ppy/osu/assets/22874522/435ce215-749a-4d00-893a-98341a7b4d4f)|![pr-loading](https://github.com/ppy/osu/assets/22874522/5693af3f-844e-459e-812e-33a540f3d26d)|

size/L

Nothing groundbreaking: slightly better performance, a bit cleaner visually. |master|pr| |---|---| |![master-solo](https://github.com/ppy/osu/assets/22874522/4aa29c02-af7e-4d5a-8886-72b5c1d544eb)|![pr-solo](https://github.com/ppy/osu/assets/22874522/f7494cef-900e-4de4-a4cc-b792e6987285)| |![master-results](https://github.com/ppy/osu/assets/22874522/e2599d52-19a1-43b3-94ee-89e96e5b9db5)|![pr-results](https://github.com/ppy/osu/assets/22874522/4ccc7358-1904-4b80-9930-dfdd329e7a0a)|

type:performance
area:results
size/L

Part 2 of https://github.com/ppy/osu-framework/pull/6145 Hide whitespace to ease the review.

type:code-quality
size/XL

|master|pr| |---|---| |![master](https://github.com/ppy/osu/assets/22874522/9ce30267-5a2e-4d18-a8fc-0efd0e94ccc1)|![pr](https://github.com/ppy/osu/assets/22874522/162cecbf-b75d-4e03-bd95-c57ebc11162a)| Last big one is caused by `.Reverse()` in https://github.com/ppy/osu/blob/ef413c08f19a0743a2aa7020aa72047118828adb/osu.Game/Screens/Edit/Compose/Components/Timeline/TimelineBlueprintContainer.cs#L130 since it allocates a new array under the hood. Needs rethinking probably.

size/M

- [ ] Depends on framework build with https://github.com/ppy/osu-framework/pull/6185 Removes enumerator allocations in https://github.com/ppy/osu/blob/4d4d69521ff8eac4a6f95b02610cd5f5392678ed/osu.Game.Rulesets.Osu/Objects/Drawables/SliderInputManager.cs#L234 ![Снимок экрана 2024-02-19 011818](https://github.com/ppy/osu/assets/22874522/9a10e9f1-ae6c-4061-8e2e-9d9d97359dc2)

size/XS

Some design elements require sampling colour from the texture. This implementation covers this functionality in the simplest way possible - getting average colour of non-transparent pixels. However I'm marking this...

size/L

A step towards resolving https://github.com/ppy/osu-framework/issues/5986. `TextureAtlas` has been reworked to support new `IRectanglePacker` interface, so switching the algorithm is a one line change. For now it's using the same algo...

size/XXL

Suppose we have 2 textures to be added into the atlas: one is wide and another is tall (images 1 & 2). Now if we want to add another texture...

type:performance