DylanDylann

Results 174 comments of DylanDylann

@shubham1206agra When changing the country, we need to collect the account number and bank information as we did when changing currency https://github.com/user-attachments/assets/da93ad28-bb85-45ab-9078-1e5d17766fcf

@shubham1206agra Please add confirm button on currency selector screen as design

@shubham1206agra From this [comment](https://github.com/Expensify/App/pull/52322#issuecomment-2498083829), I think we need to fix it on the BE side instead of disabling it (or maybe note to do it later). For now, if we...

~@shubham1206agra From design doc, we apply offline pattern C for Country/Currency and Confirm Button. For other fields, I think we still need to apply offline pattern B~ https://github.com/user-attachments/assets/30370b1d-412f-4885-93a2-157432f60d79 cc @MonilBhavsar

@shubham1206agra > @DylanDylann What do you mean here? Ref: https://github.com/Expensify/App/blob/main/contributingGuides/OFFLINE_UX.md

@shubham1206agra What do you think about my other comments?

@shubham1206agra > @DylanDylann I know the patterns, but can you elaborate where do I need to apply Pattern B? For all other fields (except country and currency), when users edit...

@shubham1206agra What do you think about the other comments? Please let me know if there is any problem

@dominictb is working on [another PR](https://github.com/Expensify/react-native-onyx/pull/602), I am not sure if they also get paid on this issue or on another issue

@jayeshmangwani @carlosmiceli How can we handle this PR to get it merged? Should we create a flag to hide this feature and only display these pages when all done