Update to react-native-nitro-sqlite

[mountiny]

As discussed in this thread, the react-native-quick-sqlite package is being migrated to react-native-nitro-sqlite and the original place where we are pulling the library from was deprecated leading to issues when running the native App.

Solution

Switch to the react-native-nitro-sqlite library pointing to the old code and the migrate to the new version of react-native-nitro-sqlite cc @chrispader

Issue Owner

Current Issue Owner: @chrispader

[melvin-bot[bot]]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot[bot]]

💬 A slack conversation has been started in #expensify-open-source

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

Handling it

[mountiny]

PR cped

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.66-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/53049

If no regressions arise, payment will be issued on 2024-12-03. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment (Needs manual offer from BZ)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot[bot]]

@shubham1206agra / @DylanDylann @puneetlath @shubham1206agra / @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[chrispader]

@mountiny just created two PRs that migrate Onyx and E/App to react-native-nitro-sqlite.

We'd need to first merge the Onyx PR and then update the NPM package version of PR accordingly.

PRs:

• https://github.com/Expensify/react-native-onyx/pull/602
• https://github.com/Expensify/App/pull/53149

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.67-9 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/53049

If no regressions arise, payment will be issued on 2024-12-05. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment (Needs manual offer from BZ)
• @DylanDylann requires payment (Needs manual offer from BZ)
• @dominictb requires payment (Needs manual offer from BZ)

[melvin-bot[bot]]

@shubham1206agra / @DylanDylann / @dominictb @puneetlath @shubham1206agra / @DylanDylann / @dominictb The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot[bot]]

Issue is ready for payment but no BZ is assigned. @Christinadobrzyn you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot[bot]]

Payment Summary

Upwork Job

• ROLE: @shubham1206agra paid $(AMOUNT) via Upwork (LINK)
• ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)
• ROLE: @dominictb paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@Christinadobrzyn)

• [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
• [ ] I have verified the payment summary above is correct

[mountiny]

not done

[Christinadobrzyn]

Thanks for the heads up @mountiny can you confirm if this is an accurate list of contributors working on this? I only see @shubham1206agra and @DylanDylann on the PR.

[DylanDylann]

@dominictb is working on another PR, I am not sure if they also get paid on this issue or on another issue

[Christinadobrzyn]

Ah thanks @DylanDylann!

Hum, it looks like https://github.com/Expensify/react-native-onyx/pull/602 is still being worked on but https://github.com/Expensify/App/pull/53049 can be paid.

@mountiny do you think it would be best for us to create a separate payment for https://github.com/Expensify/react-native-onyx/pull/602 or keep them together?

[mountiny]

@Christinadobrzyn Whatever works for you, you can pay @DylanDylann now I think and we can unassign them

[melvin-bot[bot]]

@chrispader @mountiny @Christinadobrzyn @shubham1206agra @DylanDylann @dominictb this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

@chrispader, @mountiny, @Christinadobrzyn, @shubham1206agra, @DylanDylann, @dominictb Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Christinadobrzyn]

Sounds good -

Payment for PR - https://github.com/Expensify/App/pull/53049

Contributor: @DylanDylann paid $250 via Upwork (https://www.upwork.com/nx/wm/offer/105260846)

@DylanDylann can you accept this offer? TY

Paid on 4-22-25 @DylanDylann

[mountiny]

@chrispader What is your ETA for other changes?

[Christinadobrzyn]

Just a heads up that I'm going to be ooo Dec 12 - 13th. Back on Monday 16th. I'm not going to assign this to a BZ teammate but if anything is urgent, please reach out to the team for a volunteer.

[Christinadobrzyn]

@chrispader can you provide an update when you have a moment (re)? TY!

[chrispader]

Yes, sorry for the delay. I've been trying to set up my bank account and wallet on my testing account, ~but @mountiny told me that this is only possible for US people.~

I therefore won't be able to reproduce this issue in the app. I'm trying to repro this another way.

Other than that, i think the current PRs are ready and working.

Edit: I'll have to setup VBBA and reimbursement on my account. Will continue testing tmrw

[Christinadobrzyn]

Hi @chrispader please let us know if you have an update or need any help with testing!

[melvin-bot[bot]]

@chrispader, @mountiny, @Christinadobrzyn, @shubham1206agra, @DylanDylann, @dominictb Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot[bot]]

@chrispader, @mountiny, @Christinadobrzyn, @shubham1206agra, @DylanDylann, @dominictb Still overdue 6 days?! Let's take care of this!