DylanDylann

Results 96 comments of DylanDylann

@s77rt I can't reproduce your bug https://github.com/Expensify/App/assets/141406735/03b0edac-0b34-44ef-bcbb-b606e7e4b88c Could you help to point out the step to create this request?

@s77rt Thanks for your commit suggestion. I updated

@s77rt From [your comment](https://github.com/Expensify/App/pull/35137#discussion_r1469965851), I think we should revert this change in [here](https://github.com/Expensify/App/pull/35137#discussion_r1468320899). I agree with you that > it will be much confusing to see isDraft false yet still...

Note that in case 3: we only call `setDraftSplitTransaction` if `isDraft is true` and `iouType === CONST.IOU.TYPE.SPLIT`. Draft in `isDraft` and draft in `setDraftSplitTransaction` are different. Draft in `isDraft` is...

@s77rt > Creating/Editing a split request => isDraft = true (and a comment explaining the reason) We still need to use `action` param to check if it is Creating/editing a...

> Is that the current behavior on main? Don't we save to splitTransactionDraft? @s77rt Yes, it is current behavior on main

@s77rt [This PR](https://github.com/Expensify/App/pull/34947) is reverted

@s77rt > Can you please link to that? As far as I can see we use completeSplitBill in SplitBillDetailsPage and the draft is coming from SPLIT_TRANSACTION_DRAFT You mean the link...

@s77rt Sorry, I forgot to ping you again. I updated

[Added comment](https://github.com/Expensify/App/pull/35137#discussion_r1472211843)