Dominique Makowski

It could be technically feasible to "cross-validate" heartbeats location in ``nk.bio_process()` that can take one ppg and one ecg together. I'm not sure how "using known time relations between them"...

Hi @FMJanot, welcome to github As you can see; the SR of your data is below NK's default cleaning method filtering range: https://github.com/neuropsychology/NeuroKit/blob/c1104386655724a5c624e740abf651c939fc5e48/neurokit2/eda/eda_clean.py#L81-L84 You could try using the other method,...

Let's try to merge this ASAP

I give up for today 🤯

Alright let's release this bad boy

Hi @lzdh, currently no we don't have that, but it'd be a nice addition if someone was keen on contributing :)

Fixing peaks is a tricky issue, but there's definitely room for improvement! n°3 should be a starting point, then I don't know about what's best between 1 and 2... but...

> Should I open a new PR? Sorry I didn't notice these earlier 🙈 No worries, better late than never :) Yes please do open a PR

Hi @Yashaswini278, thanks for volunteering! but actually I think we just recently did it in https://github.com/neuropsychology/NeuroKit/pull/663, but feel free to give it a look and double-check whether everything looks in...

Will keep that in mind! Are you interested mostly in ECG signal processing (e.g., peak detection) or more like feature extraction (e.g., HRV etc)?