Dominique Makowski

On top of that, I note that base R gives way nicer results that python: ``` r signal = c(3, 3, 5, 7, 1, 3, 5, 3, 5, 6, 1,...

so `min_frequency` by default is 0. This is always below what welch can do, which means that the warning will always show if we don't manually change `min_frequency`. What we...

why not sanitize the min freq to the minimum possible value (instead of 0.001)? Even at this level, I don't see why people would still want impossible values?

Thanks for the suggestion, currently it doesn't seem possible through GitHub but we should look into it indeed :) @Tam-Pham @zen-juen @JanCBrammer here are the supported platforms for sponsorship: https://github.com/neuropsychology/NeuroKit/blob/d01111b9b82364d28da01c002e6cbfc45d9493d9/.github/FUNDING.yml#L1-L12...

That's a good idea, would you mind contributing a PR with this feature :) ?

No worries, we'll fix it then. Thanks a lot for letting us know!

Thanks for all this info! So currently the main RSP-processing-related functions are the following: https://github.com/neuropsychology/NeuroKit/blob/c1104386655724a5c624e740abf651c939fc5e48/neurokit2/rsp/rsp_process.py#L67-L77 i.e., cleaning, peak detection, and phase - amplitude. Currently, these functions have usually a `method`...

can we close that @Tam-Pham ?

Hi, could you attach a piece of reproducible code and data for us to see what's going on? Thanks

@Tam-Pham ?