dproofreaders

dproofreaders copied to clipboard

Js linting

1

Best to review this by commits. They are distinct. The first commit upgrades packages and node versions, we should probably accept this commit. The second commits removes the basic format...

chrismiceli

Partial fix for issue #1274, converting exec() to Process()

1

I tested in the development VM. I tested the translators change from the Translation Center page, as an admin, deleted the locale is_IS and verified the files and directories were...

mrducky4

remove <script> from page_table.inc

3

contribution to issue #1298 Sandbox at: https://www.pgdp.org/~rp31/c.branch/unscript_project

70ray

The types were easy to infer from the usage. This exposed that the function `maybe_redirect_to_external_faq` was always redirecting due to the fallback to English if there was no lang-specific override....

jchaffraix

Whittle away at inline `<script>` tags

8

Ideally we would have no inline JS which would allow us to tighten down our Content Security Policy. That's going to be hard to remove entirely, but if we can...

cpeel

Convert system/exec usages to Symfony's Process class

2

Replace all applicable uses of [exec](https://secure.php.net/manual/en/function.exec.php), [passthru](https://secure.php.net/manual/en/function.passthru.php), [shell_exec](https://secure.php.net/manual/en/function.shell-exec.php) and [system](https://secure.php.net/manual/en/function.system.php) with Symfony's [Process](https://symfony.com/doc/5.x/components/process.html) class. The package/class was introduced into the codebase in https://github.com/DistributedProofreaders/dproofreaders/pull/1273 Add a CI script that checks these...

cpeel

Revert "Allow image to scroll beyond edges (#1010)"

2

This reverts commit c09a0e4fc8ae5cf9461bdb10edfa5265a5b31597. until we can deal with iPad problems which outweigh advantages

70ray

Implement a new site configuration approach

1

To configure the DProofreaders code, right now one edits a shell script -- an example of which is in `./SETUP/configuration.sh` -- and then runs the `./SETUP/configure` script. That script searches...

cpeel

Enable a better local dev experience with vargrant and/or docker/rancher

2

Doing local development on the DProofreaders codebase is hard. The only prescribed method right now is the [development VM](https://www.pgdp.net/wiki/DP_Code_Development_VM) which is big and bulky and requires VirtualBox or VMWorkstation /...

cpeel

Implement standard logging interface

1

PHP has no standard logging interface (unlike Python's robust [logging module](https://docs.python.org/3/library/logging.html)). All it has is [error_log()](https://www.php.net/manual/en/function.error-log) which dumps a string out to the `php_errors` file. We use this feature in...

cpeel