dproofreaders icon indicating copy to clipboard operation
dproofreaders copied to clipboard

Convert system/exec usages to Symfony's Process class

Open cpeel opened this issue 1 year ago • 2 comments

Replace all applicable uses of exec, passthru, shell_exec and system with Symfony's Process class. The package/class was introduced into the codebase in https://github.com/DistributedProofreaders/dproofreaders/pull/1273

Add a CI script that checks these functions aren't used in the code with an approve-list for files we've allowed as an exceptions. Since this is security related, we might change check_security.sh into a PHP file similar to check_includes.php and put it in there but other approaches are fine.

cpeel avatar Jul 11 '24 16:07 cpeel

Note: iterative work on this issue is appreciated, it doesn't need to be solved all at once.

cpeel avatar Jul 11 '24 16:07 cpeel

I will start working on this.

mrducky4 avatar Aug 04 '24 21:08 mrducky4