dproofreaders icon indicating copy to clipboard operation
dproofreaders copied to clipboard

Js linting

Open chrismiceli opened this issue 1 year ago • 1 comments

Best to review this by commits. They are distinct.

The first commit upgrades packages and node versions, we should probably accept this commit.

The second commits removes the basic format checks our current linter did and replaces them with prettier, an opinionated (although slightly configurable formatter) that is common in the industry. I've done some basic config to minimize the changes, but it does touch quite a few of our js files. This commit is up for discussion if this is something we want.

chrismiceli avatar Aug 15 '24 02:08 chrismiceli

I'm fine with this. Can you also write something in SETUP/CODE_STYLE.md about prettier?

Great reminder. I've updated that documentation.

chrismiceli avatar Aug 17 '24 02:08 chrismiceli

@chrismiceli - can you please squash the branch so it has two commits:

  1. update node, deps (current first commit)
  2. everything with prettier

Then I'll get it merged in.

cpeel avatar Aug 18 '24 23:08 cpeel

@chrismiceli - can you please squash the branch so it has two commits:

1. update node, deps (current first commit)

2. everything with prettier

Then I'll get it merged in.

Good idea. Rebased off latest master and combined commits.

chrismiceli avatar Aug 19 '24 01:08 chrismiceli