Dario Nieuwenhuis

Results 442 comments of Dario Nieuwenhuis
trafficstars

I mean this divider https://github.com/embassy-rs/embassy/blob/38f26137fc67beb874aa73c9a7ab2150d9f3d372/examples/rp/src/bin/wifi_tcp_server.rs#L67

I'm wondering, this alone doesn't fix the whole problem right? we also have to ensure all drivers deregister all their wakers on drop, otherwise they'll stay there forever keeping a...

Is this something you're considering doing in esp-hal? How're you planning of dealing with "the extra code to do that would be "waste" when running with embassy-executor"? just accept the...

I'm having trouble imagining a driver that could benefit from this. If a driver wants inverted gpio, it can always just exchange is_high/is_low, set_high/set_low.

The thing is the GPIO traits are explicitly for GPIO, ie they get/set the physical voltage on a digital pin. They're not "logical active/inactive signal input". Adding support for inversion...

> InvertedInputPin adapting from InputPin to InputPin this is the "lying" that I think is bad. For example, `InputSwitch` should take `InputPin, enum{ ActiveHigh, ActiveLow}` and handle the inversion itself....

> What is Endpoint::wait_enabled? Is it just waiting for Driver::start to be called? it waits for the endpoint to be enabled. "enabled/disabled" is a thing defined by USB. For example...

I see the sort of problems you're facing... I think you're the first person to try a driver for an SPI-USB chip. MCU peripherals where all the IO is volatile...

Have you measured how much compile time this saves? IMO features make sense if they prevent pulling in big dependencies, but in this case they just prevent compiling a few...