Dario Nieuwenhuis

Putting a single bool in the generated data is too "ad hoc". I think the data should contain the full info of which peripheral+register+field to set to enable the remap....

Up to you! However, it seems it's turning out to be quite complex. Maybe it's easier to just enter enter the data manually? There's not that many remaps and they're...

either a new yaml, or just put the data in a .rs file like we already do with the memory maps.

looking good! two things: - There's remaps that are split in two bits. I think it'd be cleaner to merge them into a single 2-bit field, then represent the values...

> - *_RMP and _*RMP2 are distinct fields in the register, they are not adjacent bits. Technically, it'd make sense to set them in one instruction, but then we'd need...

lgtm, thanks! :rocket:

i'm a bit worried about the symlink. Does it work well if you clone the repo from Windows and run the generation?

thanks!

yeah it's a known problem, i've seen this before. My guess is some HashMap somewhere that causes the randomness, switching to BTreeMap should fix it.

- I do think the address should come from stm32-data. - We're already doing a "create a magic peripheral" thing for VREFINTCAL https://github.com/embassy-rs/stm32-data/tree/main/data/extra/family - though IMO it's better if the...