stm32-data icon indicating copy to clipboard operation
stm32-data copied to clipboard

Adding FMPI2C to F4xx family.

Open taylorh140 opened this issue 1 year ago • 4 comments

This adds the FMPI2C i2c devices, but it was a bit difficult because only one i2c version is allowed per chip. This was fixed by adding a symlink to i2c_v2.yaml which was named i2c2_v2.yaml allows both devices to exist on the same chip and keeps the yaml file contents aligned.

taylorh140 avatar Sep 26 '24 03:09 taylorh140

diff: https://ci.embassy.dev/jobs/2ce73898f967/artifacts/diff.html

embassy-ci[bot] avatar Sep 26 '24 03:09 embassy-ci[bot]

i'm a bit worried about the symlink. Does it work well if you clone the repo from Windows and run the generation?

Dirbaio avatar Sep 26 '24 13:09 Dirbaio

Good question. I can try it later. Or if you prefer just replace it with a copy. Ntfs supports symbolic links afaik.

taylorh140 avatar Sep 26 '24 13:09 taylorh140

So @Dirbaio I would test that, but it looks like windows builds are broken on main: image

So, I as long as they don't work... I can't really tell if they stop working with my changes. 🤣 windows, right?

taylorh140 avatar Sep 26 '24 17:09 taylorh140

So I figured out I could use WSL to do the d download-all in the folder and then execute the rest on windows. And your right! something doesn't work well: image So I'll go ahead and make the change.

taylorh140 avatar Sep 29 '24 06:09 taylorh140

diff: https://ci.embassy.dev/jobs/6c31807f2944/artifacts/diff.html

embassy-ci[bot] avatar Sep 29 '24 06:09 embassy-ci[bot]

thanks!

Dirbaio avatar Sep 29 '24 20:09 Dirbaio